New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

finish promote/demote with audit #717

Merged
merged 1 commit into from Oct 9, 2018

Conversation

Projects
None yet
3 participants
@elliott-davis
Member

elliott-davis commented Oct 9, 2018

Signed-off-by: Elliott Davis elliott@excellent.io

@thesentinels

This comment has been minimized.

Show comment
Hide comment
@thesentinels

thesentinels Oct 9, 2018

Contributor

Thanks for the pull request! Here is what will happen next:

  1. Your PR will be reviewed by the maintainers
  2. If everything looks good, one of them will approve it, and your PR will be merged.

Thank you for contributing!

Contributor

thesentinels commented Oct 9, 2018

Thanks for the pull request! Here is what will happen next:

  1. Your PR will be reviewed by the maintainers
  2. If everything looks good, one of them will approve it, and your PR will be merged.

Thank you for contributing!

@chefsalim

Consider removing commented out code

Elliott Davis
finish promote/demote with audit
Signed-off-by: Elliott Davis <elliott@excellent.io>

@elliott-davis elliott-davis merged commit c2d797e into master Oct 9, 2018

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
DCO This commit has a DCO Signed-off-by line

@elliott-davis elliott-davis deleted the elliott/finish_channels branch Oct 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment