New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redo search from the ground up using full text search #770

Merged
merged 1 commit into from Nov 1, 2018

Conversation

Projects
None yet
3 participants
@elliott-davis
Member

elliott-davis commented Nov 1, 2018

Move search into a direct db diesel query. Unfortuantely there are some trait bound
issues that prevents us from merging search and search_distinct into the same function.

Ignore the duplication and you'll be just fineeee.

Signed-off-by: Elliott Davis elliott@excellent.io

@thesentinels

This comment has been minimized.

Contributor

thesentinels commented Nov 1, 2018

Thanks for the pull request! Here is what will happen next:

  1. Your PR will be reviewed by the maintainers
  2. If everything looks good, one of them will approve it, and your PR will be merged.

Thank you for contributing!

Elliott Davis
Redo search from the ground up using full text search
Move search into a direct db diesel query. Unfortuantely there are some trait bound
issues that prevents us from merging search and search_distinct into the same function.

Ignore the duplication and you'll be just fineeee.

Signed-off-by: Elliott Davis <elliott@excellent.io>

@elliott-davis elliott-davis merged commit 0236ee7 into master Nov 1, 2018

2 checks passed

DCO This commit has a DCO Signed-off-by line
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@elliott-davis elliott-davis deleted the elliott/fts branch Nov 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment