New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perf and monitoring improvements to builder-api #775

Merged
merged 3 commits into from Nov 3, 2018

Conversation

Projects
None yet
3 participants
@chefsalim
Member

chefsalim commented Nov 3, 2018

This PR makes a few key improvements to open up perf for the direct DB builder API. Since getting a DB connection/making a DB call are blocking operations, we need to ensure we avoid those in the high volume paths. With the changes here, we are able to serve all high volume calls (including authentication/authorization via personal access tokens) without hitting the DB. Leveraging memcache for origin membership also allows us to make some other key simplifications. Finally, counter metrics are added for every DB API in the builder-db models.

tenor-268071921

chefsalim added some commits Nov 3, 2018

Perf fixes and caching
Signed-off-by: Salim Alam <salam@chef.io>
Add DBCall counter metrics to model
Signed-off-by: Salim Alam <salam@chef.io>
Update memcache tracing
Signed-off-by: Salim Alam <salam@chef.io>
@thesentinels

This comment has been minimized.

Contributor

thesentinels commented Nov 3, 2018

Thanks for the pull request! Here is what will happen next:

  1. Your PR will be reviewed by the maintainers
  2. If everything looks good, one of them will approve it, and your PR will be merged.

Thank you for contributing!

@chefsalim chefsalim merged commit 6bb1df4 into master Nov 3, 2018

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
DCO This commit has a DCO Signed-off-by line

@chefsalim chefsalim deleted the SA/perf-fixes branch Nov 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment