New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better proxy support for builder-api #783

Merged
merged 1 commit into from Nov 7, 2018

Conversation

Projects
None yet
3 participants
@chefsalim
Member

chefsalim commented Nov 7, 2018

This PR improves http/https proxy support in builder. It uses the env_proxy crate to determine the proxy settings, which takes no_proxy into account. The use case is primarily for on-prem builder.

Signed-off-by: Salim Alam salam@chef.io

tenor-9234196

Better proxy support for builder-api
Signed-off-by: Salim Alam <salam@chef.io>

@chefsalim chefsalim requested a review from raskchanky as a code owner Nov 7, 2018

@thesentinels

This comment has been minimized.

Contributor

thesentinels commented Nov 7, 2018

Thanks for the pull request! Here is what will happen next:

  1. Your PR will be reviewed by the maintainers
  2. If everything looks good, one of them will approve it, and your PR will be merged.

Thank you for contributing!

@chefsalim chefsalim merged commit f3e5776 into master Nov 7, 2018

2 checks passed

DCO This commit has a DCO Signed-off-by line
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@chefsalim chefsalim deleted the SA/no-proxy branch Nov 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment