New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix target handling for package upload #798

Merged
merged 1 commit into from Nov 11, 2018

Conversation

Projects
None yet
5 participants
@chefsalim
Member

chefsalim commented Nov 10, 2018

Bug fix and some minor cleanup to package upload target handling - previously we were falling back to a default Linux target if no target was specified by the client on upload - however that failed for Windows packages where the hab client is not explicitly specifying a target in the url.

Signed-off-by: Salim Alam salam@chef.io

tenor-84017365

Fix target handling for package upload
Signed-off-by: Salim Alam <salam@chef.io>
@thesentinels

This comment has been minimized.

Contributor

thesentinels commented Nov 10, 2018

Thanks for the pull request! Here is what will happen next:

  1. Your PR will be reviewed by the maintainers
  2. If everything looks good, one of them will approve it, and your PR will be merged.

Thank you for contributing!

@scotthain

I can't speak to the rust syntax being correct, but the logic works functionally.

@raskchanky

This comment has been minimized.

Member

raskchanky commented Nov 10, 2018

On the upside, if the rust syntax wasn't correct, it wouldn't compile 😁

@chefsalim chefsalim merged commit 8f1e2e6 into master Nov 11, 2018

2 checks passed

DCO This commit has a DCO Signed-off-by line
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@chefsalim chefsalim deleted the SA/upload-target branch Nov 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment