Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Airlock component from builder #978

Merged
merged 1 commit into from Mar 14, 2019

Conversation

Projects
None yet
4 participants
@chefsalim
Copy link
Member

chefsalim commented Mar 13, 2019

This is the last part of the Airlock transition - this removes the Airlock component from builder repo, and also removes it as a dep for builder-worker, along with some associated tweaks.

Signed-off-by: Salim Alam salam@chef.io

tenor-170761497

Remove Airlock component from builder
Signed-off-by: Salim Alam <salam@chef.io>
@thesentinels

This comment has been minimized.

Copy link
Contributor

thesentinels commented Mar 13, 2019

Thanks for the pull request! Here is what will happen next:

  1. Your PR will be reviewed by the maintainers
  2. If everything looks good, one of them will approve it, and your PR will be merged.

Thank you for contributing!

@chefsalim chefsalim requested a review from raskchanky as a code owner Mar 13, 2019

@@ -12,7 +12,7 @@ env:
global:
- PATH=$HOME/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/bin:$HOME/.cargo/bin:$PATH
# Habitat Rust program components
- _RUST_HAB_BIN_COMPONENTS="components/airlock"
- _RUST_HAB_BIN_COMPONENTS=""

This comment has been minimized.

@raskchanky

raskchanky Mar 13, 2019

Member

Is this worth keeping at all if it's empty?

This comment has been minimized.

@chefsalim

chefsalim Mar 13, 2019

Author Member

Yeah I started to remove all the bin plumbing but we may have a new bin tool in the (near to mid term) future so leaving it in for now..

@@ -1,5 +1,5 @@
UNAME_S := $(shell uname -s)
BIN = airlock
BIN =

This comment has been minimized.

@raskchanky

raskchanky Mar 13, 2019

Member

Same question here as above. Why not just delete the whole thing?

@raskchanky
Copy link
Member

raskchanky left a comment

A few minor questions but nothing that should hold up merging. Looks great.

@raskchanky

This comment has been minimized.

Copy link
Member

raskchanky commented Mar 13, 2019

@elliott-davis
Copy link
Contributor

elliott-davis left a comment

@chefsalim chefsalim merged commit 2401e2e into master Mar 14, 2019

2 checks passed

DCO This commit has a DCO Signed-off-by line
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@chefsalim chefsalim deleted the SA/remove-airlock branch Mar 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.