Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Airlock component from builder #978

Merged
merged 1 commit into from Mar 14, 2019
Merged
Changes from all commits
Commits
File filter...
Filter file types
Jump to…
Jump to file or symbol
Failed to load files and symbols.
+3 −2,574
Diff settings

Always

Just for now

Copy path View file
@@ -1,6 +1,3 @@
[airlock]
plan_path = "components/airlock"

[builder-api-proxy]
plan_path = "components/builder-api-proxy/habitat"
paths = [
Copy path View file
@@ -12,7 +12,7 @@ env:
global:
- PATH=$HOME/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/bin:$HOME/.cargo/bin:$PATH
# Habitat Rust program components
- _RUST_HAB_BIN_COMPONENTS="components/airlock"
- _RUST_HAB_BIN_COMPONENTS=""

This comment has been minimized.

Copy link
@raskchanky

raskchanky Mar 13, 2019

Member

Is this worth keeping at all if it's empty?

This comment has been minimized.

Copy link
@chefsalim

chefsalim Mar 13, 2019

Author Member

Yeah I started to remove all the bin plumbing but we may have a new bin tool in the (near to mid term) future so leaving it in for now..

# Builder Rust program components
- _RUST_BLDR_BIN_COMPONENTS="components/builder-api components/builder-jobsrv components/builder-worker"
# Builder Rust crate components
Copy path View file
@@ -1,5 +1,4 @@
* @chefsalim @eeyun @raskchanky
components/airlock @chefsalim @eeyun @raskchanky
components/builder-worker @chefsalim @eeyun @raskchanky
support @chefsalim @eeyun @raskchanky @baumanj
tools @chefsalim @eeyun @raskchanky @christophermaier
Copy path View file

Some generated files are not rendered by default. Learn more.

Oops, something went wrong.
Copy path View file
@@ -3,7 +3,6 @@ debug = true

[workspace]
members = [
"components/airlock",
"components/builder-api",
"components/builder-core",
"components/builder-db",
Copy path View file
@@ -1,5 +1,5 @@
UNAME_S := $(shell uname -s)
BIN = airlock
BIN =

This comment has been minimized.

Copy link
@raskchanky

raskchanky Mar 13, 2019

Member

Same question here as above. Why not just delete the whole thing?

LIB = builder-db builder-core github-api-client
SRV = builder-api builder-jobsrv builder-worker
ALL = $(BIN) $(LIB) $(SRV)
Copy path View file

This file was deleted.

Oops, something went wrong.
Copy path View file

This file was deleted.

Oops, something went wrong.
Oops, something went wrong.
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.