Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[devshell] Add a non-root user, jdoe, for root/sudo checking codepaths. #1456

Merged
merged 1 commit into from Nov 5, 2016

Conversation

fnichol
Copy link
Collaborator

@fnichol fnichol commented Nov 4, 2016

An arbitrary user such as this ends up being used over and over in
testing situations that having a known non-root user is useful for
Habitat developers. The user is jdoe with a simple password of 1234
and who is also in the sudo group (thus being able to use sudo
commands).

gif-keyboard-14029776973537934149

An arbitrary user such as this ends up being used over and over in
testing situations that having a known non-root user is useful for
Habitat developers. The user is `jdoe` with a simple password of `1234`
and who is also in the `sudo` group (thus being able to use `sudo`
commands).

Signed-off-by: Fletcher Nichol <fnichol@nichol.ca>
@fnichol fnichol added the Chore label Nov 4, 2016
@thesentinels
Copy link
Contributor

Thanks for the pull request! Here is what will happen next:

  1. Your PR will be reviewed by the maintainers
  2. If everything looks good, one of them will approve it, and your PR will be merged.

Thank you for contributing!

@mwrock
Copy link
Contributor

mwrock commented Nov 5, 2016

@thesentinels approve

@thesentinels
Copy link
Contributor

🤘 I am testing your branch against master before merging it. We do this to ensure that the master branch is never failing tests.

@thesentinels
Copy link
Contributor

:neckbeard: Travis CI has started testing this PR.

@mwrock mwrock added the Studio label Nov 5, 2016
@thesentinels
Copy link
Contributor

💖 Travis CI reports this PR passed.

It always makes me feel nice when humans approve of one anothers work. I'm merging this PR now.

I just want you and the contributor to answer me one question:

gif-keyboard-3280869874741411265

@thesentinels thesentinels merged commit 42f7d2c into master Nov 5, 2016
@thesentinels thesentinels deleted the fnichol/devshell-add-non-root-user branch November 5, 2016 00:18
@eeyun eeyun added A-studio and removed Studio labels Jun 6, 2017
@christophermaier christophermaier added Focus: Studio Related to the Habitat Studio (core/hab-studio) component Type: Chore Issues for general code and infrastructure maintenance and removed A-studio labels Jul 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Focus: Studio Related to the Habitat Studio (core/hab-studio) component Type: Chore Issues for general code and infrastructure maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants