Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hab] Disable config apply & file upload on Mac and Windows systems. #1592

Merged
merged 1 commit into from Dec 22, 2016

Conversation

fnichol
Copy link
Collaborator

@fnichol fnichol commented Dec 21, 2016

As of the 0.14.0 release, the two subcommands config apply and file upload are provided by an accompanying Habitat package
core/hab-butterfly which is installed on first use similar to the
behavior of the sup and studio subcommands on Linux. As the Depot
software currently doesn't support multiple target systems we cannot
simply download the required package and proceed. As such, until we can
provide a better experience for this on Mac and Windows, a message will
be displayed to users explaining that these subcommands are not
currently supported.

The following would be displayed:

> target/debug/hab config apply
∅ Running `config apply` on this operating system is not currently supported. Try running this command again on a 64-bit Linux operating system.

✗✗✗
✗✗✗ Subcommand `config apply' not supported on this operating system
✗✗✗

gif-keyboard-2448706760253377657

As of the 0.14.0 release, the two subcommands `config apply` and `file
upload` are provided by an accompanying Habitat package
`core/hab-butterfly` which is installed on first use similar to the
behavior of the `sup` and `studio` subcommands on Linux. As the Depot
software currently doesn't support multiple target systems we cannot
simply download the required package and proceed. As such, until we can
provide a better experience for this on Mac and Windows, a message will
be displayed to users explaining that these subcommands are not
currently supported.

The following would be displayed:

```
> target/debug/hab config apply
∅ Running `config apply` on this operating system is not currently supported. Try running this command again on a 64-bit Linux operating system.

✗✗✗
✗✗✗ Subcommand `config apply' not supported on this operating system
✗✗✗
```

Signed-off-by: Fletcher Nichol <fnichol@nichol.ca>
@fnichol fnichol added the Bug label Dec 21, 2016
@thesentinels
Copy link
Contributor

Thanks for the pull request! Here is what will happen next:

  1. Your PR will be reviewed by the maintainers
  2. If everything looks good, one of them will approve it, and your PR will be merged.

Thank you for contributing!

@reset
Copy link
Collaborator

reset commented Dec 22, 2016

gif-keyboard-11818690423648201552

@thesentinels approve

@thesentinels
Copy link
Contributor

🤘 I am testing your branch against master before merging it. We do this to ensure that the master branch is never failing tests.

@thesentinels
Copy link
Contributor

:neckbeard: Travis CI has started testing this PR.

@thesentinels
Copy link
Contributor

💖 Travis CI reports this PR passed.

It always makes me feel nice when humans approve of one anothers work. I'm merging this PR now.

I just want you and the contributor to answer me one question:

gif-keyboard-3280869874741411265

@thesentinels thesentinels merged commit 97b7efc into master Dec 22, 2016
@thesentinels thesentinels deleted the fnichol/disable-apply-upload-nonlinux branch December 22, 2016 00:19
@eeyun eeyun added C-bug and removed Bug labels Jun 6, 2017
@christophermaier christophermaier added Type: Bug Issues that describe broken functionality and removed C-bug labels Jul 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issues that describe broken functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants