New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[devshell] Re-add `redis-server` pkg for `make bldr-run-shell` target. #1598

Merged
merged 1 commit into from Dec 22, 2016

Conversation

Projects
None yet
4 participants
@fnichol
Member

fnichol commented Dec 22, 2016

I made an incorrect assumption that the redis-server Ubuntu package
was not being used for anything, when it was for running the Builder
service stack via the make bldr-run-shell script. This change readds
that package to the default "devshell".

gif-keyboard-6325974613419619595

[devshell] Re-add `redis-server` pkg for `make bldr-run-shell` target.
I made an incorrect assumption that the `redis-server` Ubuntu package
was not being used for anything, when it was for running the Builder
service stack via the `make bldr-run-shell` script. This change readds
that package to the default "devshell".

Signed-off-by: Fletcher Nichol <fnichol@nichol.ca>

@fnichol fnichol added Bug labels Dec 22, 2016

@thesentinels

This comment has been minimized.

Show comment
Hide comment
@thesentinels

thesentinels Dec 22, 2016

Contributor

Thanks for the pull request! Here is what will happen next:

  1. Your PR will be reviewed by the maintainers
  2. If everything looks good, one of them will approve it, and your PR will be merged.

Thank you for contributing!

Contributor

thesentinels commented Dec 22, 2016

Thanks for the pull request! Here is what will happen next:

  1. Your PR will be reviewed by the maintainers
  2. If everything looks good, one of them will approve it, and your PR will be merged.

Thank you for contributing!

@reset reset merged commit 5328d5b into master Dec 22, 2016

3 checks passed

DCO This commit has a DCO Signed-off-by line
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@reset reset deleted the fnichol/devshell-readd-redis-server branch Dec 22, 2016

@reset

This comment has been minimized.

Show comment
Hide comment
@reset

reset Dec 22, 2016

Member

Good catch!

gif-keyboard-5166927647261727844

Member

reset commented Dec 22, 2016

Good catch!

gif-keyboard-5166927647261727844

@eeyun eeyun added C-bug C-chore and removed Bug labels Jun 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment