New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement graceful shutdown on windows #1603

Merged
merged 1 commit into from Dec 24, 2016

Conversation

Projects
None yet
5 participants
@mwrock
Contributor

mwrock commented Dec 23, 2016

Signed-off-by: Matt Wrock matt@mattwrock.com

@thesentinels

This comment has been minimized.

Show comment
Hide comment
@thesentinels

thesentinels Dec 23, 2016

Contributor

Thanks for the pull request! Here is what will happen next:

  1. Your PR will be reviewed by the maintainers
  2. If everything looks good, one of them will approve it, and your PR will be merged.

Thank you for contributing!

Contributor

thesentinels commented Dec 23, 2016

Thanks for the pull request! Here is what will happen next:

  1. Your PR will be reviewed by the maintainers
  2. If everything looks good, one of them will approve it, and your PR will be merged.

Thank you for contributing!

@reset

reset approved these changes Dec 23, 2016

A couple of comments inline but looks good!

Show outdated Hide outdated components/core/src/os/process/windows.rs Outdated
implement graceful shutdown on windows
Signed-off-by: Matt Wrock <matt@mattwrock.com>
@mwrock

This comment has been minimized.

Show comment
Hide comment
@mwrock

mwrock Dec 24, 2016

Contributor

@thesentinels approve

Contributor

mwrock commented Dec 24, 2016

@thesentinels approve

@thesentinels

This comment has been minimized.

Show comment
Hide comment
@thesentinels

thesentinels Dec 24, 2016

Contributor

🤘 I am testing your branch against master before merging it. We do this to ensure that the master branch is never failing tests.

Contributor

thesentinels commented Dec 24, 2016

🤘 I am testing your branch against master before merging it. We do this to ensure that the master branch is never failing tests.

@thesentinels

This comment has been minimized.

Show comment
Hide comment
@thesentinels
Contributor

thesentinels commented Dec 24, 2016

:neckbeard: Travis CI has started testing this PR.

@thesentinels

This comment has been minimized.

Show comment
Hide comment
@thesentinels

thesentinels Dec 24, 2016

Contributor

💖 Travis CI reports this PR passed.

It always makes me feel nice when humans approve of one anothers work. I'm merging this PR now.

I just want you and the contributor to answer me one question:

gif-keyboard-3280869874741411265

Contributor

thesentinels commented Dec 24, 2016

💖 Travis CI reports this PR passed.

It always makes me feel nice when humans approve of one anothers work. I'm merging this PR now.

I just want you and the contributor to answer me one question:

gif-keyboard-3280869874741411265

@thesentinels thesentinels merged commit d089cc2 into master Dec 24, 2016

3 checks passed

DCO This commit has a DCO Signed-off-by line
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@thesentinels thesentinels deleted the kill_windows branch Dec 24, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment