New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure the requestor is a member of the origin, not the person invited. #1609

Merged
merged 1 commit into from Dec 29, 2016

Conversation

Projects
None yet
6 participants
@raskchanky
Member

raskchanky commented Dec 28, 2016

Rather than check if the person we're inviting is a member of the origin, which doesn't make any sense, let's instead check if the person sending the invite is a member of the origin. This resolves the Unauthorized message that appears when you invite someone to an origin.

Signed-off-by: Josh Black raskchanky@gmail.com

Ensure the requestor is a member of the origin, not the person invited.
Signed-off-by: Josh Black <raskchanky@gmail.com>
@thesentinels

This comment has been minimized.

Show comment
Hide comment
@thesentinels

thesentinels Dec 28, 2016

Contributor

Thanks for the pull request! Here is what will happen next:

  1. Your PR will be reviewed by the maintainers
  2. If everything looks good, one of them will approve it, and your PR will be merged.

Thank you for contributing!

Contributor

thesentinels commented Dec 28, 2016

Thanks for the pull request! Here is what will happen next:

  1. Your PR will be reviewed by the maintainers
  2. If everything looks good, one of them will approve it, and your PR will be merged.

Thank you for contributing!

@mwrock

mwrock approved these changes Dec 29, 2016 edited

@thesentinels approve

@raskchanky

This comment has been minimized.

Show comment
Hide comment
@raskchanky
Member

raskchanky commented Dec 29, 2016

@thesentinels approve

@thesentinels

This comment has been minimized.

Show comment
Hide comment
@thesentinels

thesentinels Dec 29, 2016

Contributor

🤘 I am testing your branch against master before merging it. We do this to ensure that the master branch is never failing tests.

Contributor

thesentinels commented Dec 29, 2016

🤘 I am testing your branch against master before merging it. We do this to ensure that the master branch is never failing tests.

@thesentinels

This comment has been minimized.

Show comment
Hide comment
@thesentinels
Contributor

thesentinels commented Dec 29, 2016

:neckbeard: Travis CI has started testing this PR.

@thesentinels

This comment has been minimized.

Show comment
Hide comment
@thesentinels

thesentinels Dec 29, 2016

Contributor

💖 Travis CI reports this PR passed.

It always makes me feel nice when humans approve of one anothers work. I'm merging this PR now.

I just want you and the contributor to answer me one question:

gif-keyboard-3280869874741411265

Contributor

thesentinels commented Dec 29, 2016

💖 Travis CI reports this PR passed.

It always makes me feel nice when humans approve of one anothers work. I'm merging this PR now.

I just want you and the contributor to answer me one question:

gif-keyboard-3280869874741411265

@thesentinels thesentinels merged commit a429c9c into master Dec 29, 2016

3 checks passed

DCO This commit has a DCO Signed-off-by line
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@thesentinels thesentinels deleted the invite-failure branch Dec 29, 2016

@reset

This comment has been minimized.

Show comment
Hide comment
@reset

reset Jan 2, 2017

Member

@raskchanky good catch!

Member

reset commented Jan 2, 2017

@raskchanky good catch!

@fnichol fnichol added Bug labels Jan 19, 2017

@eeyun eeyun added A-builder C-bug and removed Builder labels Jun 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment