New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn users if Docker's file sharing isn't enabled. #1611

Merged
merged 2 commits into from Jan 1, 2017

Conversation

Projects
None yet
5 participants
@raskchanky
Member

raskchanky commented Dec 30, 2016

If people don't have file sharing enabled in Docker for Mac, then hab studio enter will fail when it's run with an error message that looks like this:

screen shot 2016-12-30 at 3 12 53 pm

This isn't the best user experience. I couldn't find a way of detecting whether file sharing was enabled, either via the command line tools or the Docker Remote API. Instead, we simulate a call to hab studio -V to check the version of the studio. This has the effect of mounting the same directories that would be mounted when running a studio and if it fails with a particular kind of error message, we notice and tell the user about it. Now the error message looks like this:

screen shot 2016-12-30 at 3 13 25 pm

I have no idea how this will work on Windows, as I don't have a Windows machine or VM to check on. Perhaps @smurawski or @mwrock can weigh in with their thoughts.

Signed-off-by: Josh Black raskchanky@gmail.com

@thesentinels

This comment has been minimized.

Show comment
Hide comment
@thesentinels

thesentinels Dec 30, 2016

Contributor

Thanks for the pull request! Here is what will happen next:

  1. Your PR will be reviewed by the maintainers
  2. If everything looks good, one of them will approve it, and your PR will be merged.

Thank you for contributing!

Contributor

thesentinels commented Dec 30, 2016

Thanks for the pull request! Here is what will happen next:

  1. Your PR will be reviewed by the maintainers
  2. If everything looks good, one of them will approve it, and your PR will be merged.

Thank you for contributing!

Warn users if Docker's file sharing isn't enabled.
Signed-off-by: Josh Black <raskchanky@gmail.com>
@mwrock

This comment has been minimized.

Show comment
Hide comment
@mwrock

mwrock Dec 31, 2016

Contributor

Very Nice!! It doesen't break windows but we can also check for drive is not shared which should apply this same UX enhancement to Windows. I can add that to this branch and test.

Contributor

mwrock commented Dec 31, 2016

Very Nice!! It doesen't break windows but we can also check for drive is not shared which should apply this same UX enhancement to Windows. I can add that to this branch and test.

add shared drive warning for docker for windows
Signed-off-by: Matt Wrock <matt@mattwrock.com>
@mwrock

This comment has been minimized.

Show comment
Hide comment
@mwrock

mwrock Jan 1, 2017

Contributor

Added a commit to provide a similar warning for docker on windows.

Contributor

mwrock commented Jan 1, 2017

Added a commit to provide a similar warning for docker on windows.

@mwrock

This comment has been minimized.

Show comment
Hide comment
@mwrock

mwrock Jan 1, 2017

Contributor

@thesentinels approve

Contributor

mwrock commented Jan 1, 2017

@thesentinels approve

@thesentinels

This comment has been minimized.

Show comment
Hide comment
@thesentinels

thesentinels Jan 1, 2017

Contributor

🤘 I am testing your branch against master before merging it. We do this to ensure that the master branch is never failing tests.

Contributor

thesentinels commented Jan 1, 2017

🤘 I am testing your branch against master before merging it. We do this to ensure that the master branch is never failing tests.

@thesentinels

This comment has been minimized.

Show comment
Hide comment
@thesentinels

thesentinels Jan 1, 2017

Contributor

:neckbeard: Travis CI has started testing this PR.

Contributor

thesentinels commented Jan 1, 2017

:neckbeard: Travis CI has started testing this PR.

@thesentinels

This comment has been minimized.

Show comment
Hide comment
@thesentinels

thesentinels Jan 1, 2017

Contributor

💖 Travis CI reports this PR passed.

It always makes me feel nice when humans approve of one anothers work. I'm merging this PR now.

I just want you and the contributor to answer me one question:

gif-keyboard-3280869874741411265

Contributor

thesentinels commented Jan 1, 2017

💖 Travis CI reports this PR passed.

It always makes me feel nice when humans approve of one anothers work. I'm merging this PR now.

I just want you and the contributor to answer me one question:

gif-keyboard-3280869874741411265

@thesentinels thesentinels merged commit f374f60 into master Jan 1, 2017

3 checks passed

DCO This commit has a DCO Signed-off-by line
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@thesentinels thesentinels deleted the docker-file-sharing branch Jan 1, 2017

@fnichol fnichol added the Feature label Jan 19, 2017

@eeyun eeyun added C-feature and removed Feature labels Jun 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment