New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg_upstream_url is required in core plans #1612

Merged
merged 1 commit into from Jan 3, 2017

Conversation

Projects
None yet
5 participants
@jtimberman
Member

jtimberman commented Jan 3, 2017

When using hab plan init to create a new core plan, we will fail the build in travis because we're enforcing that all packages have a project home page - pkg_upstream_url:

https://github.com/habitat-sh/core-plans/blob/master/bin/check-default-variables.sh

Signed-off-by: Joshua Timberman joshua@chef.io

pkg_upstream_url is required in core plans
When using `hab plan init` to create a new core plan, we will fail the
build in travis because we're enforcing that all packages have a
project home page - `pkg_upstream_url`:

https://github.com/habitat-sh/core-plans/blob/master/bin/check-default-variables.sh

Signed-off-by: Joshua Timberman <joshua@chef.io>
@thesentinels

This comment has been minimized.

Show comment
Hide comment
@thesentinels

thesentinels Jan 3, 2017

Contributor

Thanks for the pull request! Here is what will happen next:

  1. Your PR will be reviewed by the maintainers
  2. If everything looks good, one of them will approve it, and your PR will be merged.

Thank you for contributing!

Contributor

thesentinels commented Jan 3, 2017

Thanks for the pull request! Here is what will happen next:

  1. Your PR will be reviewed by the maintainers
  2. If everything looks good, one of them will approve it, and your PR will be merged.

Thank you for contributing!

@reset

This comment has been minimized.

Show comment
Hide comment
@reset
Member

reset commented Jan 3, 2017

gif-keyboard-4633625276421096238

@thesentinels approve

@thesentinels

This comment has been minimized.

Show comment
Hide comment
@thesentinels

thesentinels Jan 3, 2017

Contributor

🤘 I am testing your branch against master before merging it. We do this to ensure that the master branch is never failing tests.

Contributor

thesentinels commented Jan 3, 2017

🤘 I am testing your branch against master before merging it. We do this to ensure that the master branch is never failing tests.

@thesentinels

This comment has been minimized.

Show comment
Hide comment
@thesentinels

thesentinels Jan 3, 2017

Contributor

:neckbeard: Travis CI has started testing this PR.

Contributor

thesentinels commented Jan 3, 2017

:neckbeard: Travis CI has started testing this PR.

@thesentinels

This comment has been minimized.

Show comment
Hide comment
@thesentinels

thesentinels Jan 3, 2017

Contributor

💖 Travis CI reports this PR passed.

It always makes me feel nice when humans approve of one anothers work. I'm merging this PR now.

I just want you and the contributor to answer me one question:

gif-keyboard-3280869874741411265

Contributor

thesentinels commented Jan 3, 2017

💖 Travis CI reports this PR passed.

It always makes me feel nice when humans approve of one anothers work. I'm merging this PR now.

I just want you and the contributor to answer me one question:

gif-keyboard-3280869874741411265

@thesentinels thesentinels merged commit 23afffd into master Jan 3, 2017

3 checks passed

DCO This commit has a DCO Signed-off-by line
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@thesentinels thesentinels deleted the jtimberman/upstream-url branch Jan 3, 2017

@fnichol fnichol added the Feature label Jan 19, 2017

@eeyun eeyun added C-feature and removed Feature labels Jun 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment