New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail powershell based builds if non terminating errors occur #1616

Merged
merged 1 commit into from Jan 5, 2017

Conversation

Projects
None yet
5 participants
@mwrock
Contributor

mwrock commented Jan 5, 2017

Powershell divides errors into terminating and non-terminating errors. By default, a terminating error will halt a script but non-terminating errors will emit the error to the console and then proceed. This behavior is fitting for many ad hoc scripts that process multiple items in a powershell pipeline and do not want to terminate if a single item fails. However for our purposes during a habitat package build, any error should halt the build.

fail powershell based builds if non terminating errors occur
Signed-off-by: Matt Wrock <matt@mattwrock.com>
@thesentinels

This comment has been minimized.

Show comment
Hide comment
@thesentinels

thesentinels Jan 5, 2017

Contributor

Thanks for the pull request! Here is what will happen next:

  1. Your PR will be reviewed by the maintainers
  2. If everything looks good, one of them will approve it, and your PR will be merged.

Thank you for contributing!

Contributor

thesentinels commented Jan 5, 2017

Thanks for the pull request! Here is what will happen next:

  1. Your PR will be reviewed by the maintainers
  2. If everything looks good, one of them will approve it, and your PR will be merged.

Thank you for contributing!

@reset

This comment has been minimized.

Show comment
Hide comment
@reset
Member

reset commented Jan 5, 2017

@thesentinels approve

@thesentinels

This comment has been minimized.

Show comment
Hide comment
@thesentinels

thesentinels Jan 5, 2017

Contributor

🤘 I am testing your branch against master before merging it. We do this to ensure that the master branch is never failing tests.

Contributor

thesentinels commented Jan 5, 2017

🤘 I am testing your branch against master before merging it. We do this to ensure that the master branch is never failing tests.

@thesentinels

This comment has been minimized.

Show comment
Hide comment
@thesentinels

thesentinels Jan 5, 2017

Contributor

:neckbeard: Travis CI has started testing this PR.

Contributor

thesentinels commented Jan 5, 2017

:neckbeard: Travis CI has started testing this PR.

@thesentinels

This comment has been minimized.

Show comment
Hide comment
@thesentinels

thesentinels Jan 5, 2017

Contributor

💖 Travis CI reports this PR passed.

It always makes me feel nice when humans approve of one anothers work. I'm merging this PR now.

I just want you and the contributor to answer me one question:

gif-keyboard-3280869874741411265

Contributor

thesentinels commented Jan 5, 2017

💖 Travis CI reports this PR passed.

It always makes me feel nice when humans approve of one anothers work. I'm merging this PR now.

I just want you and the contributor to answer me one question:

gif-keyboard-3280869874741411265

@thesentinels thesentinels merged commit 47c3fa0 into master Jan 5, 2017

3 checks passed

DCO This commit has a DCO Signed-off-by line
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@thesentinels thesentinels deleted the stop_error branch Jan 5, 2017

@mwrock mwrock restored the stop_error branch Jan 5, 2017

@reset reset deleted the stop_error branch Jan 5, 2017

@fnichol

This comment has been minimized.

Show comment
Hide comment
@fnichol

fnichol Jan 19, 2017

Member

YES!

Member

fnichol commented Jan 19, 2017

YES!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment