New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix integer overflow cast causing longer than expected thread sleeps #1625

Merged
merged 1 commit into from Jan 6, 2017

Conversation

Projects
None yet
5 participants
@reset
Member

reset commented Jan 6, 2017

We should always check if we have a positive wait time before casting a
signed integer into an unsigned integer. This fixes a few different
server loops by ensuring this check is made.

gif-keyboard-7288508588526934601

Fix integer overflow cast causing longer than expected thread sleeps
We should always check if we have a positive wait time before casting a
signed integer into an unsigned integer. This fixes a few different
server loops by ensuring this check is made.

Signed-off-by: Jamie Winsor <jamie@vialstudios.com>
@thesentinels

This comment has been minimized.

Show comment
Hide comment
@thesentinels

thesentinels Jan 6, 2017

Contributor

Thanks for the pull request! Here is what will happen next:

  1. Your PR will be reviewed by the maintainers
  2. If everything looks good, one of them will approve it, and your PR will be merged.

Thank you for contributing!

Contributor

thesentinels commented Jan 6, 2017

Thanks for the pull request! Here is what will happen next:

  1. Your PR will be reviewed by the maintainers
  2. If everything looks good, one of them will approve it, and your PR will be merged.

Thank you for contributing!

@mwrock

mwrock approved these changes Jan 6, 2017

@mwrock

This comment has been minimized.

Show comment
Hide comment
@mwrock

mwrock Jan 6, 2017

Contributor

@thesentinels approve

Contributor

mwrock commented Jan 6, 2017

@thesentinels approve

@thesentinels

This comment has been minimized.

Show comment
Hide comment
@thesentinels

thesentinels Jan 6, 2017

Contributor

🤘 I am testing your branch against master before merging it. We do this to ensure that the master branch is never failing tests.

Contributor

thesentinels commented Jan 6, 2017

🤘 I am testing your branch against master before merging it. We do this to ensure that the master branch is never failing tests.

@thesentinels

This comment has been minimized.

Show comment
Hide comment
@thesentinels

thesentinels Jan 6, 2017

Contributor

:neckbeard: Travis CI has started testing this PR.

Contributor

thesentinels commented Jan 6, 2017

:neckbeard: Travis CI has started testing this PR.

@thesentinels

This comment has been minimized.

Show comment
Hide comment
@thesentinels

thesentinels Jan 6, 2017

Contributor

💖 Travis CI reports this PR passed.

It always makes me feel nice when humans approve of one anothers work. I'm merging this PR now.

I just want you and the contributor to answer me one question:

gif-keyboard-3280869874741411265

Contributor

thesentinels commented Jan 6, 2017

💖 Travis CI reports this PR passed.

It always makes me feel nice when humans approve of one anothers work. I'm merging this PR now.

I just want you and the contributor to answer me one question:

gif-keyboard-3280869874741411265

@thesentinels thesentinels merged commit 7c0e89e into master Jan 6, 2017

3 checks passed

DCO This commit has a DCO Signed-off-by line
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@thesentinels thesentinels deleted the fix-thread-sleeps branch Jan 6, 2017

@fnichol fnichol added Bug labels Jan 19, 2017

@eeyun eeyun added A-supervisor C-bug and removed Supervisor labels Jun 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment