Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes homepage scripts and in turn fixes css rendering #2371

Merged
merged 1 commit into from May 15, 2017

Conversation

ryankeairns
Copy link
Contributor

After deploying the blog, we noticed that the home page styles weren't rendering correctly and there was a javascript error.

After digging into it, the issue was related to an issue with how javascript files are dynamically included in middlemanapp via middlemanapp-sprockets. Researching indicated that if you point at a newer version of middleman-sprockets that the javascript require functionality would work again... and so it did.

The only side effect was that it no longer could handle the radial gradient backgrounds that we were using on the home page, so I had to make some very minor tweaks to those css rules (removing an unrecognizable parameter).

Signed-off-by: Ryan Keairns rkeairns@chef.io

Signed-off-by: Ryan Keairns <rkeairns@chef.io>
@thesentinels
Copy link
Contributor

Thanks for the pull request! Here is what will happen next:

  1. Your PR will be reviewed by the maintainers
  2. If everything looks good, one of them will approve it, and your PR will be merged.

Thank you for contributing!

@reset
Copy link
Collaborator

reset commented May 15, 2017

@thesentinels approve

@thesentinels
Copy link
Contributor

🤘 I am testing your branch against master before merging it. We do this to ensure that the master branch is never failing tests.

@thesentinels
Copy link
Contributor

:neckbeard: Travis CI has started testing this PR.

@reset
Copy link
Collaborator

reset commented May 15, 2017

tenor-36742729

@thesentinels
Copy link
Contributor

💖 Travis CI reports this PR passed.

It always makes me feel nice when humans approve of one anothers work. I'm merging this PR now.

I just want you and the contributor to answer me one question:

gif-keyboard-3280869874741411265

@thesentinels thesentinels merged commit b9cfd6a into master May 15, 2017
@thesentinels thesentinels deleted the rk/homepage-script branch May 15, 2017 23:33
@ryankeairns
Copy link
Contributor Author

ryankeairns commented May 15, 2017

Notes for a future-proof fix:

https://forum.middlemanapp.com/t/how-to-add-javascripts-in-middleman-4/2689

Sprockets was removed from middleman core, to fix this we could continue using sprockets by:

  • set to the last version gem 'middleman-sprockets', '~> 4.1.0' and activate it manually it in our config.rb with activate :sprockets
    or, better yet
  • use an external js build tool like webpack to handle our js bundling

@christophermaier christophermaier added Type: Chore Issues for general code and infrastructure maintenance and removed C-chore labels Jul 24, 2020
@christophermaier christophermaier added Documentation Flags an issue / PR for attention by the technical documentation team and removed A-documentation labels Aug 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Flags an issue / PR for attention by the technical documentation team Type: Chore Issues for general code and infrastructure maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants