Fix handler crash on account creation when duplicate email is present #3777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We key on account name and not email. A long while ago when the account table was first created it wasn't clear if we would key on email or account because we weren't sure which we could be guaranteed to get. It's now clear that name is what we can guarantee and we will perform email verification steps to try our best to obtain an email. This change fixes a crash in the session server when a user without an email tries to create an account in a shard where another user has already created an account without an email. Signed-off-by: Jamie Winsor <jamie@vialstudios.com>
|
Thanks for the pull request! Here is what will happen next:
Thank you for contributing! |
raskchanky
approved these changes
Oct 13, 2017
|
|
christophermaier
added
Type: Bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We key on account name and not email. A long while ago when the account table
was first created it wasn't clear if we would key on email or account because
we weren't sure which we could be guaranteed to get. It's now clear that name
is what we can guarantee and we will perform email verification steps to try
our best to obtain an email.
This change fixes a crash in the session server when a user without an email
tries to create an account in a shard where another user has already created
an account without an email.