Improve asset compilation in Builder UI #3905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change makes a few minor improvements to asset compilation in Builder: * Removes CSS linting from compilation (we have a separate task for that) * Builds CSS once before watching in the development environment (as passing `—watch` suppresses initial compilation) * Removes CSS and JS source maps from production builds * Single quotes in the Webpack config Signed-off-by: Christian Nunciato <cnunciato@chef.io>
cnunciato
requested review from
chefsalim,
raskchanky and
reset
as code owners
|
Thanks for the pull request! Here is what will happen next:
Thank you for contributing! |
chefsalim
reviewed
Oct 25, 2017
| @@ -1,6 +1,8 @@ | |||
| #!/bin/sh | |||
| set -x | |||
|
|
|||
| npm run build-css -- --source-map=true | |||
There was a problem hiding this comment.
What is the reasoning for source-map=true here? Since we are only doing compression in production, do we need source mapping at all now?
There was a problem hiding this comment.
This script is only run in dev, and yeah, we do use it in dev.
|
|
chefsalim
approved these changes
Oct 25, 2017
|
@thesentinels approve |
|
🤘 I am testing your branch against master before merging it. We do this to ensure that the master branch is never failing tests. |
|
|
Travis CI has
|
💖 Travis CI reports this PR passed. It always makes me feel nice when humans approve of one anothers work. I'm merging this PR now. I just want you and the contributor to answer me one question:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes a few minor improvements to asset compilation in Builder:
--watchsuppresses initial compilation)Signed-off-by: Christian Nunciato cnunciato@chef.io
Fixes #3526.