New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plan.sh - Wrap license value in double quotes #4150

Merged
merged 1 commit into from Nov 29, 2017

Conversation

Projects
None yet
3 participants
@nathenharvey

nathenharvey commented Nov 29, 2017

Every other string value in the default template uses double-quoted strings. This updates the pkg_license to a value of ("Apache-2.0") instead of ('Apache-2.0')

@thesentinels

This comment has been minimized.

Contributor

thesentinels commented Nov 29, 2017

Thanks for the pull request! Here is what will happen next:

  1. Your PR will be reviewed by the maintainers
  2. If everything looks good, one of them will approve it, and your PR will be merged.

Thank you for contributing!

@christophermaier

This comment has been minimized.

Contributor

christophermaier commented Nov 29, 2017

@nathenharvey would you mind squashing these into a single commit?

Nathen Harvey
Wrap license value in double quotes
Every other string value in the default template uses double-quoted
strings.  This updates the `pkg_license` to a value of `("Apache-2.0")`
instead of `('Apache-2.0')`

Signed-off-by: Nathen Harvey <nharvey@chef.io>
@nathenharvey

This comment has been minimized.

nathenharvey commented Nov 29, 2017

@christophermaier squashed!

@christophermaier

This comment has been minimized.

Contributor

christophermaier commented Nov 29, 2017

@nathenharvey Thanks!

@thesentinels approve

@thesentinels

This comment has been minimized.

Contributor

thesentinels commented Nov 29, 2017

🤘 I am testing your branch against master before merging it. We do this to ensure that the master branch is never failing tests.

@thesentinels

This comment has been minimized.

Contributor

thesentinels commented Nov 29, 2017

:neckbeard: Travis CI has started testing this PR.

@thesentinels

This comment has been minimized.

Contributor

thesentinels commented Nov 29, 2017

💖 Travis CI reports this PR passed.

It always makes me feel nice when humans approve of one anothers work. I'm merging this PR now.

I just want you and the contributor to answer me one question:

gif-keyboard-3280869874741411265

@thesentinels thesentinels merged commit d0e31ae into habitat-sh:master Nov 29, 2017

2 of 3 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
DCO This commit has a DCO Signed-off-by line
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@nathenharvey nathenharvey deleted the nathenharvey:nathen/double-quotes branch Nov 29, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment