New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Null column to have value before setting it to not null #4216

Merged
merged 1 commit into from Dec 5, 2017

Conversation

Projects
None yet
5 participants
@elliott-davis
Member

elliott-davis commented Dec 5, 2017

tenor-154253924
Signed-off-by: Travis Elliott Davis edavis@chef.io

Travis Elliott Davis
Migrate Null column to have value before setting it to not null
Signed-off-by: Travis Elliott Davis <edavis@chef.io>
@thesentinels

This comment has been minimized.

Contributor

thesentinels commented Dec 5, 2017

Thanks for the pull request! Here is what will happen next:

  1. Your PR will be reviewed by the maintainers
  2. If everything looks good, one of them will approve it, and your PR will be merged.

Thank you for contributing!

@christophermaier

This comment has been minimized.

Contributor

christophermaier commented Dec 5, 2017

tenor-65139172

@thesentinels approve

@thesentinels

This comment has been minimized.

Contributor

thesentinels commented Dec 5, 2017

🤘 I am testing your branch against master before merging it. We do this to ensure that the master branch is never failing tests.

@thesentinels

This comment has been minimized.

Contributor

thesentinels commented Dec 5, 2017

:neckbeard: Travis CI has started testing this PR.

@raskchanky

This comment has been minimized.

Member

raskchanky commented Dec 5, 2017

tenor-35240980

@chefsalim chefsalim merged commit eed4f33 into master Dec 5, 2017

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
DCO This commit has a DCO Signed-off-by line
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@raskchanky raskchanky deleted the elliott/fix_with_gusto branch Dec 5, 2017

@thesentinels

This comment has been minimized.

Contributor

thesentinels commented Dec 5, 2017

💔 Travis CI reports this PR failed to pass the test suite.

The next step is to examine the job and figure out why. If it is transient, you can try re-triggering the Travis CI Job - if it passes, this PR will be automatically merged. If it is not transient, you should fix the issue and update this pull request, and issue approve again. If you believe it will never pass, and you are feeling :godmode:, you can issue a force to merge this PR anyway.

@thesentinels

This comment has been minimized.

Contributor

thesentinels commented Dec 5, 2017

:neckbeard: Travis CI has started testing this PR.

@thesentinels

This comment has been minimized.

Contributor

thesentinels commented Dec 5, 2017

💔 Travis CI reports this PR failed to pass the test suite.

The next step is to examine the job and figure out why. If it is transient, you can try re-triggering the Travis CI Job - if it passes, this PR will be automatically merged. If it is not transient, you should fix the issue and update this pull request, and issue approve again. If you believe it will never pass, and you are feeling :godmode:, you can issue a force to merge this PR anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment