New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable integration name check since we removed the db column it was checking #4262

Merged
merged 1 commit into from Dec 8, 2017

Conversation

Projects
None yet
4 participants
@elliott-davis
Member

elliott-davis commented Dec 7, 2017

tenor-251163135

Signed-off-by: Travis Elliott Davis edavis@chef.io

Travis Elliott Davis
Disable integration name check since we removed the db column it was …
…checking

Signed-off-by: Travis Elliott Davis <edavis@chef.io>
@thesentinels

This comment has been minimized.

Contributor

thesentinels commented Dec 7, 2017

Thanks for the pull request! Here is what will happen next:

  1. Your PR will be reviewed by the maintainers
  2. If everything looks good, one of them will approve it, and your PR will be merged.

Thank you for contributing!

@raskchanky

This comment has been minimized.

Member

raskchanky commented Dec 7, 2017

tenor-224139855

@cnunciato

This comment has been minimized.

Member

cnunciato commented Dec 7, 2017

@thesentinels approve

@thesentinels

This comment has been minimized.

Contributor

thesentinels commented Dec 7, 2017

🤘 I am testing your branch against master before merging it. We do this to ensure that the master branch is never failing tests.

@elliott-davis

This comment has been minimized.

Member

elliott-davis commented Dec 7, 2017

@thesentinels approve

@thesentinels

This comment has been minimized.

Contributor

thesentinels commented Dec 7, 2017

🤘 I am testing your branch against master before merging it. We do this to ensure that the master branch is never failing tests.

@thesentinels

This comment has been minimized.

Contributor

thesentinels commented Dec 7, 2017

:neckbeard: Travis CI has started testing this PR.

@thesentinels

This comment has been minimized.

Contributor

thesentinels commented Dec 8, 2017

💖 Travis CI reports this PR passed.

It always makes me feel nice when humans approve of one anothers work. I'm merging this PR now.

I just want you and the contributor to answer me one question:

gif-keyboard-3280869874741411265

@thesentinels thesentinels merged commit b84e3bc into master Dec 8, 2017

3 checks passed

DCO This commit has a DCO Signed-off-by line
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@thesentinels thesentinels deleted the elliott/disable_default_check branch Dec 8, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment