do not check mounts entering windows container studio #4668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: mwrock <matt@mattwrock.com>
mwrock
requested review from
baumanj,
christophermaier,
fnichol and
reset
as code owners
|
Thanks for the pull request! Here is what will happen next:
Thank you for contributing! |
raskchanky
reviewed
Feb 26, 2018
| @@ -197,9 +201,7 @@ where | |||
| cmd_args.push(vol.as_ref().into()); | |||
| } | |||
|
|
|||
| if !is_serving_windows_containers(docker_cmd) { | |||
There was a problem hiding this comment.
Was the removal of this check intentional? Is this related to mounts too?
There was a problem hiding this comment.
since this PR would not enter this function when using windows containers, this check would always be false
raskchanky
approved these changes
Feb 26, 2018
|
|
|
@thesentinels approve |
|
🤘 I am testing your branch against master before merging it. We do this to ensure that the master branch is never failing tests. |
|
|
Travis CI has
|
💖 Travis CI reports this PR passed. It always makes me feel nice when humans approve of one anothers work. I'm merging this PR now. I just want you and the contributor to answer me one question:
|
christophermaier
added
Focus: Studio
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Windows containers do not use shared drives for mounting local volumes so the
check_mountsfunction provides no value when run in Windows container mode. Also, this incurs adocker runwhich takes much longer on Windows 10 hosts for windows containers (like ~ 20 seconds) so removing this check significantly speeds up the studio startup time.Signed-off-by: mwrock matt@mattwrock.com