New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add note about running private packages from builder #4753
Conversation
Signed-off-by: brewn <nbrewer@chef.io>
Thanks for the pull request! Here is what will happen next:
Thank you for contributing! |
Signed-off-by: brewn <nbrewer@chef.io>
@@ -83,7 +85,7 @@ $ hab start core/postgresql --channel unstable | |||
|
|||
An exported tarball package contains the Habitat client/binary as well as dependencies specified by your artifact. | |||
|
|||
After deploying the tarball to your target server, extract the contents to the _root directory_: | |||
After deploying the tarball to your target server, extract the contents to the `root` directory: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, hm. It isn't literally root
, it's /
(I actually stumbled on this verbiage when I read it for the first time, too.) Maybe we should just say "to the filesystem root directory (/
)" so the user can match that up with the /
in the example?
Signed-off-by: brewn <nbrewer@chef.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thesentinels approve |
🤘 I am testing your branch against master before merging it. We do this to ensure that the master branch is never failing tests. |
Travis CI has started testing this PR. |
Oops! Clicked the wrong button. 😄 |
💖 Travis CI reports this PR passed. It always makes me feel nice when humans approve of one anothers work. I'm merging this PR now. I just want you and the contributor to answer me one question: |
Signed-off-by: brewn nbrewer@chef.io