Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add note about running private packages from builder #4753

Merged
merged 3 commits into from Mar 16, 2018

Conversation

brewn
Copy link

@brewn brewn commented Mar 14, 2018

Signed-off-by: brewn nbrewer@chef.io

Signed-off-by: brewn <nbrewer@chef.io>
@thesentinels
Copy link
Contributor

Thanks for the pull request! Here is what will happen next:

  1. Your PR will be reviewed by the maintainers
  2. If everything looks good, one of them will approve it, and your PR will be merged.

Thank you for contributing!

@brewn
Copy link
Author

brewn commented Mar 14, 2018

#4733

Signed-off-by: brewn <nbrewer@chef.io>
@@ -83,7 +85,7 @@ $ hab start core/postgresql --channel unstable

An exported tarball package contains the Habitat client/binary as well as dependencies specified by your artifact.

After deploying the tarball to your target server, extract the contents to the _root directory_:
After deploying the tarball to your target server, extract the contents to the `root` directory:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, hm. It isn't literally root, it's / (I actually stumbled on this verbiage when I read it for the first time, too.) Maybe we should just say "to the filesystem root directory (/)" so the user can match that up with the / in the example?

Signed-off-by: brewn <nbrewer@chef.io>
Copy link
Contributor

@cnunciato cnunciato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tenor-114291585

@cnunciato
Copy link
Contributor

@thesentinels approve

@cnunciato cnunciato closed this Mar 16, 2018
@thesentinels
Copy link
Contributor

🤘 I am testing your branch against master before merging it. We do this to ensure that the master branch is never failing tests.

@cnunciato cnunciato reopened this Mar 16, 2018
@thesentinels
Copy link
Contributor

:neckbeard: Travis CI has started testing this PR.

@cnunciato
Copy link
Contributor

Oops! Clicked the wrong button. 😄

@thesentinels
Copy link
Contributor

💖 Travis CI reports this PR passed.

It always makes me feel nice when humans approve of one anothers work. I'm merging this PR now.

I just want you and the contributor to answer me one question:

gif-keyboard-3280869874741411265

@thesentinels thesentinels merged commit 3481dc7 into master Mar 16, 2018
@thesentinels thesentinels deleted the nb/private-builder branch March 16, 2018 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants