Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Rust 1.35.0 #6615

Merged
merged 3 commits into from Jun 7, 2019

Conversation

@raskchanky
Copy link
Member

commented Jun 3, 2019

This fixes some clippy issues with Rust 1.35.0, although not all of them. #6610 also fixes 1.35.0 related clippy issues, and that PR should merge before this one does in order for CI on this one to pass.

@chef-expeditor

This comment has been minimized.

Copy link

commented Jun 3, 2019

Hello raskchanky! Thanks for the pull request!

Here is what will happen next:

  1. Your PR will be reviewed by the maintainers.
  2. If everything looks good, one of them will approve it, and your PR will be merged.

Thank you for contributing!

@baumanj
Copy link
Member

left a comment

Per https://blog.rust-lang.org/2019/05/23/Rust-1.35.0.html#changes-in-clippy, I suggest we add drop_bounds and redundant_closure_for_method_calls to denied_lints.txt

@raskchanky

This comment has been minimized.

Copy link
Member Author

commented Jun 5, 2019

@baumanj Done

@baumanj

baumanj approved these changes Jun 6, 2019

@christophermaier
Copy link
Contributor

left a comment

@raskchanky This looks good to me, but I think we should have a core/rust/1.35.0 package in Builder before this goes in, just so everything is consistent.

@raskchanky

This comment has been minimized.

Copy link
Member Author

commented Jun 6, 2019

@christophermaier The PR has been up for some time habitat-sh/core-plans#2626 but nobody's looked at it yet.

raskchanky added some commits Jun 3, 2019

Update to rust 1.35.0
Signed-off-by: Josh Black <raskchanky@gmail.com>
Fix some clippy issues with rust 1.35.0
Signed-off-by: Josh Black <raskchanky@gmail.com>
Add 2 new lints in 1.35.0 to denied_lints
Signed-off-by: Josh Black <raskchanky@gmail.com>

@raskchanky raskchanky force-pushed the jb/rust-1.35.0 branch from b3b3175 to 919447e Jun 6, 2019

@raskchanky raskchanky merged commit a543d0c into master Jun 7, 2019

5 checks passed

DCO This commit has a DCO Signed-off-by
Details
buildkite/habitat-sh-habitat-master-verify Build #2200 passed (40 minutes, 25 seconds)
Details
buildkite/habitat-sh-habitat-master-website Build #2436 passed (33 seconds)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
expeditor/config-validation Validated your Expeditor config file
Details

@raskchanky raskchanky deleted the jb/rust-1.35.0 branch Jun 7, 2019

chef-ci added a commit that referenced this pull request Jun 7, 2019

Update CHANGELOG.md with details from pull request #6615
Obvious fix; these changes are the result of automation not creative thinking.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.