Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Artifactory as BuilderAPIProvider #6653

Merged
merged 1 commit into from Jun 13, 2019

Conversation

@chefsalim
Copy link
Member

commented Jun 12, 2019

This PR adds in a new Artifactory provider for the Builder API. This allows the use of Artifactory directly as a Depot, albeit with certain limitations:

  • Artifactory repos (one for each origin, named "habitat-artifact-store-local.") need to be pre-created, and users given permission appropriately by the Artifactory admin - ie, there is no origin/user management via hab
  • Only package, public/private key management, and promote/demote channel operations are supported
  • Job management or build related commands are not supported
  • All calls are authenticated - ie, a HAB_AUTH_TOKEN is required
  • Only works with Artifactory Pro version

In order to enable this feature:

export HAB_BLDR_PROVIDER=artifactory
export HAB_BLDR_URL=<your artifactory url>
export HAB_AUTH_TOKEN=<your artifactory API key>

This feature should be considered Alpha level for early adopter usage and feedback purposes.

Signed-off-by: Salim Alam salam@chef.io

tenor-68370775

NOTE TO REVIEWERS: not looking for a deep review on this, mostly please eyeball for anything obviously broken I might have blindly overlooked.

@chef-expeditor

This comment has been minimized.

Copy link

commented Jun 12, 2019

Hello chefsalim! Thanks for the pull request!

Here is what will happen next:

  1. Your PR will be reviewed by the maintainers.
  2. If everything looks good, one of them will approve it, and your PR will be merged.

Thank you for contributing!

Add Artifactory as BuilderAPIProvider
Signed-off-by: Salim Alam <salam@chef.io>

@chefsalim chefsalim force-pushed the SA/artifactory-provider branch from 5e76084 to 67fa22f Jun 13, 2019

@baumanj
Copy link
Member

left a comment

The changes to components/common and components/hab look sane; didn't look at the rest

@chefsalim chefsalim requested a review from davidMcneil Jun 13, 2019

@davidMcneil
Copy link
Contributor

left a comment

This looks good to me

@chefsalim chefsalim merged commit 5d1075c into master Jun 13, 2019

5 checks passed

DCO This commit has a DCO Signed-off-by
Details
buildkite/habitat-sh-habitat-master-verify Build #2340 passed (38 minutes, 26 seconds)
Details
buildkite/habitat-sh-habitat-master-website Build #2688 passed (1 minute, 29 seconds)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
expeditor/config-validation Validated your Expeditor config file
Details

@chefsalim chefsalim deleted the SA/artifactory-provider branch Jun 13, 2019

chef-ci added a commit that referenced this pull request Jun 13, 2019

Update CHANGELOG.md with details from pull request #6653
Obvious fix; these changes are the result of automation not creative thinking.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.