Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qubitrenegade 6644 #6655

Merged
merged 14 commits into from Jun 14, 2019

Conversation

@baumanj
Copy link
Member

commented Jun 13, 2019

This is just a workaround to run #6644 in CI since currently it won't run on PRs from external branches.

qubitrenegade added some commits Jun 7, 2019

add an env var... Build env is broken on FC29 so moving to ubuntu vm …
…for testing

Signed-off-by: qubitrenegade <qubitrenegade@gmail.com>
fix typos
Signed-off-by: qubitrenagade <qubitrenegade@gmail.com>
Add auth_token, bldr_url, and ctl_secret to variables loaded when ent…
…ering hab studio

Signed-off-by: qubitrenagade <qubitrenegade@gmail.com>
create set_env_var function to reduce some of the copy/pasting
Signed-off-by: qubitrenagade <qubitrenegade@gmail.com>
Further abstract out set_env_var_from_config to reduce copy/pasted co…
…de and make code more obvious

Signed-off-by: qubitrenagade <qubitrenegade@gmail.com>
rustfmt cleanup: `cargo +nightly-2019-03-04 fmt
Signed-off-by: qubitrenagade <qubitrenegade@gmail.com>
Don't print sensitive values with RUST_LOG=debug
Signed-off-by: qubitrenagade <qubitrenegade@gmail.com>
Use bool instead of Option<bool>
Signed-off-by: qubitrenagade <qubitrenegade@gmail.com>
Import consts from where they are defined instead of defining locally
Signed-off-by: qubitrenagade <qubitrenegade@gmail.com>
Cleanup dead code
Signed-off-by: qubitrenagade <qubitrenegade@gmail.com>
rustfmt cleanup
Signed-off-by: qubitrenagade <qubitrenegade@gmail.com>
Add Sensitivity enum to ensure sensitive information is not printed
Signed-off-by: qubitrenagade <qubitrenegade@gmail.com>
rustfmt
Signed-off-by: qubitrenagade <qubitrenegade@gmail.com>
@chef-expeditor

This comment has been minimized.

Copy link

commented Jun 13, 2019

Hello baumanj! Thanks for the pull request!

Here is what will happen next:

  1. Your PR will be reviewed by the maintainers.
  2. If everything looks good, one of them will approve it, and your PR will be merged.

Thank you for contributing!

Add traits to Enum
Add Clone and Copy traits to `Sensitivity` enum to fix "needless pass by value" clippy gripe.

Co-Authored-By: baumanj <baumanj@users.noreply.github.com>

@baumanj baumanj merged commit d3a2773 into master Jun 14, 2019

3 of 5 checks passed

DCO This commit does not have a DCO Signed-off-by
Details
buildkite/habitat-sh-habitat-master-verify Build #2374 failed (1 hour, 24 minutes, 44 seconds)
Details
buildkite/habitat-sh-habitat-master-website Build #2756 passed (1 minute, 6 seconds)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
expeditor/config-validation Validated your Expeditor config file
Details

chef-ci added a commit that referenced this pull request Jun 14, 2019

Update CHANGELOG.md with details from pull request #6655
Obvious fix; these changes are the result of automation not creative thinking.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.