Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6345 danielhertenstein #6656

Merged
merged 4 commits into from Jun 13, 2019

Conversation

@baumanj
Copy link
Member

commented Jun 13, 2019

This is just a workaround to run #6345 in CI since currently it won't run on PRs from external branches.

danielhertenstein added some commits Mar 26, 2019

Checks if default cache key path exists and tells user if it doesn't.
Signed-off-by: Daniel Hertenstein <daniel.hertenstein@gmail.com>
Removes call to default_cache_key_path()
Signed-off-by: Daniel Hertenstein <daniel.hertenstein@gmail.com>
Changes `.to_string_lossy()` calls to `.display()` calls
Signed-off-by: Daniel Hertenstein <daniel.hertenstein@gmail.com>
@chef-expeditor

This comment has been minimized.

Copy link

commented Jun 13, 2019

Hello baumanj! Thanks for the pull request!

Here is what will happen next:

  1. Your PR will be reviewed by the maintainers.
  2. If everything looks good, one of them will approve it, and your PR will be merged.

Thank you for contributing!

rustfmt changes
Signed-off-by: Daniel Hertenstein <daniel.hertenstein@gmail.com>

@baumanj baumanj merged commit 0af8ffc into master Jun 13, 2019

4 of 5 checks passed

buildkite/habitat-sh-habitat-master-verify Build #2362 failed (23 minutes, 52 seconds)
Details
DCO This commit has a DCO Signed-off-by
Details
buildkite/habitat-sh-habitat-master-website Build #2734 passed (31 seconds)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
expeditor/config-validation Validated your Expeditor config file
Details

chef-ci added a commit that referenced this pull request Jun 13, 2019

Update CHANGELOG.md with details from pull request #6656
Obvious fix; these changes are the result of automation not creative thinking.

@baumanj baumanj deleted the 6345-danielhertenstein branch Jun 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.