Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplication in BuilderAPI create #6660

Merged
merged 1 commit into from Jun 14, 2019

Conversation

@davidMcneil
Copy link
Contributor

commented Jun 14, 2019

Signed-off-by: David McNeil mcneil.david2@gmail.com

Remove duplication in BuilderAPI create
Signed-off-by: David McNeil <mcneil.david2@gmail.com>
@chef-expeditor

This comment has been minimized.

Copy link

commented Jun 14, 2019

Hello davidMcneil! Thanks for the pull request!

Here is what will happen next:

  1. Your PR will be reviewed by the maintainers.
  2. If everything looks good, one of them will approve it, and your PR will be merged.

Thank you for contributing!

@davidMcneil

This comment has been minimized.

Copy link
Contributor Author

commented Jun 14, 2019

We could take this a step further and add new and create to the BuilderAPIProvider trait. We could then have a blanket create for all BuilderAPIProviders.

@davidMcneil davidMcneil self-assigned this Jun 14, 2019

@davidMcneil davidMcneil merged commit 5149bea into master Jun 14, 2019

5 checks passed

DCO This commit has a DCO Signed-off-by
Details
buildkite/habitat-sh-habitat-master-verify Build #2382 passed (44 minutes, 28 seconds)
Details
buildkite/habitat-sh-habitat-master-website Build #2772 passed (1 minute, 33 seconds)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
expeditor/config-validation Validated your Expeditor config file
Details

chef-ci added a commit that referenced this pull request Jun 14, 2019

Update CHANGELOG.md with details from pull request #6660
Obvious fix; these changes are the result of automation not creative thinking.

@davidMcneil davidMcneil deleted the dmcneil/code-cleanup branch Jul 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.