Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed 'Habitat' to 'Chef Habitat' in documentation & blog. #6667

Merged
merged 2 commits into from Jun 24, 2019

Conversation

@IanMadd
Copy link

commented Jun 17, 2019

Signed-off-by: IanMadd maddaus@protonmail.com

Change 'Habitat' to 'Chef Habitat'.

Changed 'Habitat' to 'Chef Habitat' in documentation & blog.
Signed-off-by: IanMadd <maddaus@protonmail.com>

@IanMadd IanMadd requested a review from raskchanky as a code owner Jun 17, 2019

@chef-expeditor

This comment has been minimized.

Copy link

commented Jun 17, 2019

Hello IanMadd! Thanks for the pull request!

Here is what will happen next:

  1. Your PR will be reviewed by the maintainers.
  2. If everything looks good, one of them will approve it, and your PR will be merged.

Thank you for contributing!

Changes the Habitat header image to Chef Habitat
Signed-off-by: David McCown <dmccown@chef.io>

@markan markan self-requested a review Jun 19, 2019

@markan

markan approved these changes Jun 19, 2019

Copy link
Contributor

left a comment

This looks good to merge; in that all of the changes look correct and reasonable. As a disclaimer I didn't go looking for any possible missed items.
None of my above comments should be treated as blockers.

@@ -26,17 +26,17 @@ section

h3 .NET Framework

p If this were a .NET Core application, we could simply declare a dependency on <code>core/dotnet-core</code> which would put <code>dotnet.exe</code> on our path and we just point that to our built binary and we are done. The .NET "full framework" on the other hand wants to be in a very specific place on disk, has a key component called the Gloabal Assembly Cache (note "global") and requires some Windows registry entries to be friendly. We will deal with this by leaving the responsibility of installing the correct version of the .NET framework up to our provisioning or configuration management layer. Our ASP.NET application plan will simply assume the presense of the .NET framework in the environment where it is running. The fact of the matter is that any fully patched version of Windows that Habitat supports will have a v4 .NET CLR installed - so often the requirement of the .NET framework will already be present on a fresh Windows image. However it might be a version or two behind the latest version of the .NET 4 runtime and if your application depends on new features in those versions, then you will need to make sure to have them installed before running your application in Habitat.
p If this were a .NET Core application, we could simply declare a dependency on <code>core/dotnet-core</code> which would put <code>dotnet.exe</code> on our path and we just point that to our built binary and we are done. The .NET "full framework" on the other hand wants to be in a very specific place on disk, has a key component called the Gloabal Assembly Cache (note "global") and requires some Windows registry entries to be friendly. We will deal with this by leaving the responsibility of installing the correct version of the .NET framework up to our provisioning or configuration management layer. Our ASP.NET application plan will simply assume the presense of the .NET framework in the environment where it is running. The fact of the matter is that any fully patched version of Windows that Chef Habitat supports will have a v4 .NET CLR installed - so often the requirement of the .NET framework will already be present on a fresh Windows image. However it might be a version or two behind the latest version of the .NET 4 runtime and if your application depends on new features in those versions, then you will need to make sure to have them installed before running your application in Chef Habitat.

This comment has been minimized.

Copy link
@markan

markan Jun 19, 2019

Contributor

At some point we might want to fix 'Gloabal Assembly Cache' to be 'Global Assembly Cache'

@@ -54,7 +54,7 @@ section
$pkg_name="contosouniversity"
$pkg_origin="myorigin"
$pkg_version="0.1.0"
$pkg_maintainer="The Habitat Maintainers <humans@habitat.sh>"
$pkg_maintainer="The Chef Habitat Maintainers <humans@habitat.sh>"

This comment has been minimized.

Copy link
@markan

markan Jun 19, 2019

Contributor

This example suggests that we might want to go though the core plans repo to correct this there as well.

@scotthain scotthain merged commit 5be86c9 into master Jun 24, 2019

5 checks passed

DCO This commit has a DCO Signed-off-by
Details
buildkite/habitat-sh-habitat-master-verify Build #2407 passed (39 minutes, 42 seconds)
Details
buildkite/habitat-sh-habitat-master-website Build #2822 passed (40 seconds)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
expeditor/config-validation Validated your Expeditor config file
Details

chef-ci added a commit that referenced this pull request Jun 24, 2019

Update CHANGELOG.md with details from pull request #6667
Obvious fix; these changes are the result of automation not creative thinking.

christophermaier added a commit that referenced this pull request Jul 29, 2019

Update document generation scripts with "Chef Habitat" wording
Looks like #6667 was a bit overzealous in its grepping; it changed
some generated files, rather than making changes to the generating
code.

Additional changes to CLI documentation and template references should
take place in their source code, for consistency.

christophermaier added a commit that referenced this pull request Jul 29, 2019

Update document generation scripts with "Chef Habitat" wording
Looks like #6667 was a bit overzealous in its grepping; it changed
some generated files, rather than making changes to the generating
code.

Additional changes to CLI documentation and template references should
take place in their source code, for consistency.

Signed-off-by: Christopher Maier <cmaier@chef.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.