Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update widestring crate #6679

Merged
merged 1 commit into from Jun 21, 2019

Conversation

@mwrock
Copy link
Contributor

commented Jun 21, 2019

fixes #6456

I thought I remembered this being more convoluted in March but I was able to update the crate this time around without any code changes or failing tests. I even added one here for good measure.

Signed-off-by: mwrock matt@mattwrock.com

@baumanj
Copy link
Member

left a comment

One suggestion; by no means obligatory

@@ -67,6 +67,11 @@ mod tests {

use super::*;

#[test]
fn get_uid_of_current_user() {
assert!(get_uid_by_name(&get_current_username().unwrap()).is_some());

This comment has been minimized.

Copy link
@baumanj

baumanj Jun 21, 2019

Member

Functionally equivalent, but I find this clearer (and prefer to avoid unwraps)

Suggested change
assert!(get_uid_by_name(&get_current_username().unwrap()).is_some());
assert!(get_current_username().map(|s| get_uid_by_name(&s)).is_some())

@mwrock mwrock force-pushed the widestring branch from 8629a5c to fff92cd Jun 21, 2019

update widestring crate
Signed-off-by: mwrock <matt@mattwrock.com>

@mwrock mwrock force-pushed the widestring branch from fff92cd to 6ebaae8 Jun 21, 2019

@mwrock mwrock merged commit 6ba7cd2 into master Jun 21, 2019

5 checks passed

DCO This commit has a DCO Signed-off-by
Details
buildkite/habitat-sh-habitat-master-verify Build #2469 passed (56 minutes, 24 seconds)
Details
buildkite/habitat-sh-habitat-master-website Build #2942 passed (54 seconds)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
expeditor/config-validation Validated your Expeditor config file
Details

@mwrock mwrock deleted the widestring branch Jun 21, 2019

chef-ci added a commit that referenced this pull request Jun 21, 2019

Update CHANGELOG.md with details from pull request #6679
Obvious fix; these changes are the result of automation not creative thinking.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.