Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolve build deps before run deps #6683

Merged
merged 1 commit into from Jun 24, 2019

Conversation

@mwrock
Copy link
Contributor

commented Jun 24, 2019

fixes #6637

With this, build deps appear on the path before runtime deps.

Signed-off-by: mwrock matt@mattwrock.com

resolve build deps before run deps
Signed-off-by: mwrock <matt@mattwrock.com>

@mwrock mwrock self-assigned this Jun 24, 2019

)
for dep in "${pkg_tdeps_resolved[@]}" "${pkg_build_tdeps_resolved[@]}"; do
for dep in "${pkg_build_tdeps_resolved[@]}" "${pkg_tdeps_resolved[@]}"; do

This comment has been minimized.

Copy link
@christophermaier

christophermaier Jun 24, 2019

Contributor

Is it possible to have some tests for this behavior? It's hard to determine from reading the code if this does the right thing (or if this is reversed by the code adding these to the $PATH)

😭

@mwrock mwrock merged commit 9268201 into master Jun 24, 2019

5 checks passed

DCO This commit has a DCO Signed-off-by
Details
buildkite/habitat-sh-habitat-master-verify Build #2483 passed (49 minutes, 36 seconds)
Details
buildkite/habitat-sh-habitat-master-website Build #2968 passed (32 seconds)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
expeditor/config-validation Validated your Expeditor config file
Details

chef-ci added a commit that referenced this pull request Jun 24, 2019

Update CHANGELOG.md with details from pull request #6683
Obvious fix; these changes are the result of automation not creative thinking.

@mwrock mwrock deleted the build_then_run branch Jun 24, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.