Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provide a better error when no value is passed to Set-BuildtimeEnv or Set-RuntimeEnv #6684

Merged
merged 1 commit into from Jun 26, 2019

Conversation

@mwrock
Copy link
Contributor

commented Jun 24, 2019

fixes #6487

Signed-off-by: mwrock matt@mattwrock.com

provide a better error when no value is passed to Set-BuildtimeEnv or…
… Set-RuntimeEnv

Signed-off-by: mwrock <matt@mattwrock.com>
@davidMcneil
Copy link
Contributor

left a comment

I will preface this by saying I know next to nothing about PowerShell, but am interested in learning more.

Is there a reason we can not make $VarValue a mandatory parameter?

I assume default parameter expressions are only evaluated if no parameter is supplied? I know in some languages they are eagerly evaluated, but this does not appear to be the case.

I hope you dont mind me using this as an opportunity to learn.

@mwrock

This comment has been minimized.

Copy link
Contributor Author

commented Jun 26, 2019

No that is a great question @davidMcneil ! The problem with using mandatory params here is that those will prompt the user if not provided which is not what we want in a studio build.

@mwrock mwrock merged commit c10cd6f into master Jun 26, 2019

5 checks passed

DCO This commit has a DCO Signed-off-by
Details
buildkite/habitat-sh-habitat-master-verify Build #2491 passed (23 minutes, 16 seconds)
Details
buildkite/habitat-sh-habitat-master-website Build #2984 passed (1 minute, 27 seconds)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
expeditor/config-validation Validated your Expeditor config file
Details

@mwrock mwrock deleted the better_error branch Jun 26, 2019

chef-ci added a commit that referenced this pull request Jun 26, 2019

Update CHANGELOG.md with details from pull request #6684
Obvious fix; these changes are the result of automation not creative thinking.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.