Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fail build on docker push failures #6702

Merged
merged 1 commit into from Jul 1, 2019

Conversation

@mwrock
Copy link
Contributor

commented Jul 1, 2019

Signed-off-by: mwrock matt@mattwrock.com

@mwrock mwrock force-pushed the docker_push branch from 57edc5c to ada6bfc Jul 1, 2019

.buildkite/release_pipeline.yaml Show resolved Hide resolved
@@ -21,6 +21,9 @@ Write-Host "--- Publishing the Windows Docker Studio"
. ./results/last_image.ps1

This comment has been minimized.

Copy link
@christophermaier

christophermaier Jul 1, 2019

Contributor

I can't comment directly, but what if line 18 fails?

This comment has been minimized.

Copy link
@mwrock

mwrock Jul 1, 2019

Author Contributor

we have a check on the docker build but although the docker tags are pretty safe, we might as well guard them.

.buildkite/scripts/publish_docker_studio.ps1 Outdated Show resolved Hide resolved
fail build on docker push failures
Signed-off-by: mwrock <matt@mattwrock.com>

@mwrock mwrock force-pushed the docker_push branch from ada6bfc to fa5e052 Jul 1, 2019

@mwrock mwrock merged commit f336e04 into master Jul 1, 2019

5 checks passed

DCO This commit has a DCO Signed-off-by
Details
buildkite/habitat-sh-habitat-master-verify Build #2564 passed (36 minutes, 59 seconds)
Details
buildkite/habitat-sh-habitat-master-website Build #3118 passed (51 seconds)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
expeditor/config-validation Validated your Expeditor config file
Details

@mwrock mwrock deleted the docker_push branch Jul 1, 2019

chef-ci added a commit that referenced this pull request Jul 1, 2019

Update CHANGELOG.md with details from pull request #6702
Obvious fix; these changes are the result of automation not creative thinking.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.