Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Refactor DatFile, again #6703
It turns out that when DatFile owns the BufReader, it keeps the file
At first, I thought it should be possible to just create a BufReader
Since we store the offsets for all the different rumors, in theory it
In the interest of time and sanity, we now pass the same BufReader
Signed-off-by: Josh Black email@example.com
baumanj left a comment •
Just a couple comments here. Per offline discussion, I think we're better served by moving to a different abstraction where the reading and writing capabilities are encapsulated in different types.
If possible, getting some sort of automated testing in which can trigger the error we aim to fix with this change seems very important. It would only fail on Windows, but having it in CI rather than relying on manual validation to catch the issue would be huge.