Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Assorted health-check tweaks #6727
baumanj left a comment
The changes look good.
I wonder if we could add a test for the issue we're fixing here. I know the interfaces are far from testable in their current state, but I think if we commit to adding regression tests each time we fix an issue, we'll gradually move towards a better place. Realistically, we're not going to make big changes just for the sake of testability, but where we find bugs, more are likely to exist, so letting that direct our efforts is a reasonable principle, I think.