Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assorted health-check tweaks #6727

Merged
merged 2 commits into from Jul 31, 2019

Conversation

@christophermaier
Copy link
Contributor

commented Jul 12, 2019

See individual commits for details.

@christophermaier christophermaier self-assigned this Jul 12, 2019
Copy link
Contributor

left a comment

The changes look good.

I wonder if we could add a test for the issue we're fixing here. I know the interfaces are far from testable in their current state, but I think if we commit to adding regression tests each time we fix an issue, we'll gradually move towards a better place. Realistically, we're not going to make big changes just for the sake of testability, but where we find bugs, more are likely to exist, so letting that direct our efforts is a reasonable principle, I think.

This should have been the case all along, actually.

This also restructures the function to make it a bit more  obvious
what is happening.

Signed-off-by: Christopher Maier <cmaier@chef.io>
Everybody loves logs!

Signed-off-by: Christopher Maier <cmaier@chef.io>
@christophermaier christophermaier force-pushed the cm/health-check-logging branch from 5c32f46 to 959c51e Jul 31, 2019
@christophermaier christophermaier merged commit 5a67e4f into master Jul 31, 2019
4 checks passed
4 checks passed
DCO This commit has a DCO Signed-off-by
Details
buildkite/habitat-sh-habitat-master-verify Build #2875 passed (19 minutes, 52 seconds)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
expeditor/config-validation Validated your Expeditor config file
Details
@christophermaier christophermaier deleted the cm/health-check-logging branch Jul 31, 2019
@mwrock mwrock added the X-feature label Aug 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.