Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix javascript generation in the web site #6742

Merged
merged 1 commit into from Jul 18, 2019

Conversation

@raskchanky
Copy link
Member

commented Jul 18, 2019

This allows the side navigation to function properly again and the console is error free (other than connection refused errors from some of our analytics libraries - but those should not impact functionality).

AFAICT, at some point middleman required explicit activation of sprockets, and we missed that in one of our version bumps.

Signed-off-by: Josh Black raskchanky@gmail.com

Signed-off-by: Josh Black <raskchanky@gmail.com>
Copy link
Contributor

left a comment

Far from an expert here, but I was able to repro the failures and observe that they were fixed by these changes. So looks good to me!

@raskchanky raskchanky merged commit 5c1e5fa into master Jul 18, 2019
5 checks passed
5 checks passed
DCO This commit has a DCO Signed-off-by
Details
buildkite/habitat-sh-habitat-master-verify Build #2715 passed (33 minutes, 28 seconds)
Details
buildkite/habitat-sh-habitat-master-website Build #3398 passed (35 seconds)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
expeditor/config-validation Validated your Expeditor config file
Details
@raskchanky raskchanky deleted the jb/fix-middleman branch Jul 18, 2019
chef-ci added a commit that referenced this pull request Jul 18, 2019
Obvious fix; these changes are the result of automation not creative thinking.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.