Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hab-plan-build] Normalize file checksums before comparison #6748

Merged
merged 1 commit into from Jul 22, 2019

Conversation

@stevendanna
Copy link
Contributor

commented Jul 20, 2019

This changes our checksum comparison to be case-insensitive, allowing
user to use hexadecimal representations of the checksum that use
uppercase letters.

Fixes #5427

Signed-off-by: Steven Danna steve@chef.io

This changes our checksum comparison to be case-insensitive, allowing
user to use hexadecimal representations of the checksum that use
uppercase letters.

Fixes #5427

Signed-off-by: Steven Danna <steve@chef.io>
@stevendanna

This comment has been minimized.

Copy link
Contributor Author

commented Jul 20, 2019

Was going through some older tickets and saw this issue. This isn't a priority for me personally, but it seemed like an easy enough thing to fix. If we decide we'd rather not, let's also close the related ticket.

@mwrock mwrock self-assigned this Jul 22, 2019
@mwrock mwrock merged commit 022e2b7 into habitat-sh:master Jul 22, 2019
3 checks passed
3 checks passed
DCO This commit has a DCO Signed-off-by
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
expeditor/config-validation Validated your Expeditor config file
Details
chef-ci added a commit that referenced this pull request Jul 22, 2019
Obvious fix; these changes are the result of automation not creative thinking.
@christophermaier

This comment has been minimized.

Copy link
Contributor

commented Jul 24, 2019

@mwrock The Windows version of hab-plan-build needs this too, correct?

@christophermaier

This comment has been minimized.

Copy link
Contributor

commented Jul 24, 2019

Also, thanks for this @stevendanna !

@mwrock

This comment has been minimized.

Copy link
Contributor

commented Jul 25, 2019

Nope @christophermaier . Powershell string comparisons are case insensitive.

@christophermaier

This comment has been minimized.

Copy link
Contributor

commented Jul 25, 2019

@mwrock That's surprising. Good for us, but surprising. 🤷‍♂

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.