Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert all our manual whitespace splitting to use split_whitespace() #6751

Merged
merged 1 commit into from Jul 23, 2019

Conversation

@raskchanky
Copy link
Member

commented Jul 22, 2019

#6749 fixes one instance where split(' ') produced incorrect results because it only splits on a single space, even when multiple spaces are present.

That made me wonder - why aren't we using split_whitespace() everywhere? I can't think of a scenario where the behavior of split_whitespace() is not what we want, and for some reason, we actually depend on the behavior of split(' ') when multiple consecutive whitespace characters are present.

So I did a find/replace.

Signed-off-by: Josh Black raskchanky@gmail.com

Signed-off-by: Josh Black <raskchanky@gmail.com>
@mwrock
mwrock approved these changes Jul 23, 2019
@raskchanky raskchanky merged commit daf2239 into master Jul 23, 2019
5 checks passed
5 checks passed
DCO This commit has a DCO Signed-off-by
Details
buildkite/habitat-sh-habitat-master-verify Build #2773 passed (43 minutes, 7 seconds)
Details
buildkite/habitat-sh-habitat-master-website Build #3514 passed (1 minute, 21 seconds)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
expeditor/config-validation Validated your Expeditor config file
Details
@raskchanky raskchanky deleted the jb/fix-whitespace-everywhere branch Jul 23, 2019
chef-ci added a commit that referenced this pull request Jul 23, 2019
Obvious fix; these changes are the result of automation not creative thinking.
@christophermaier

This comment has been minimized.

Copy link
Contributor

commented Jul 24, 2019

Nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.