Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be more explicit about connection refused errors. #6755

Merged
merged 1 commit into from Jul 24, 2019

Conversation

@raskchanky
Copy link
Member

commented Jul 23, 2019

We shouldn't have been casting every IO error as a failure to connect to
a supervisor. There are a wide variety of IO errors and only one of them
means we couldn't connect to a supervisor. Now we trap that error
specifically, and display the appropriate wall of text. Other IO errors
are displayed in a more generic fashion.

Closes #6754
Signed-off-by: Josh Black raskchanky@gmail.com

We shouldn't have been casting every IO error as a failure to connect to
a supervisor. There are a wide variety of IO errors and only one of them
means we couldn't connect to a supervisor. Now we trap that error
specifically, and display the appropriate wall of text. Other IO errors
are displayed in a more generic fashion.

Signed-off-by: Josh Black <raskchanky@gmail.com>
Copy link
Contributor

left a comment

Looks like a good refinement 👍

@raskchanky raskchanky merged commit 8ec26fc into master Jul 24, 2019
5 checks passed
5 checks passed
DCO This commit has a DCO Signed-off-by
Details
buildkite/habitat-sh-habitat-master-verify Build #2807 passed (34 minutes, 24 seconds)
Details
buildkite/habitat-sh-habitat-master-website Build #3582 passed (43 seconds)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
expeditor/config-validation Validated your Expeditor config file
Details
@raskchanky raskchanky deleted the jb/better-broken-pipe-errors branch Jul 24, 2019
chef-ci added a commit that referenced this pull request Jul 24, 2019
Obvious fix; these changes are the result of automation not creative thinking.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.