Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Update http-client and builder-api-client from hyper to reqwest. #6759
This change has two significant components:
The reqwest migration allows us to remove custom handlers for proxy and SSL support and use the library implementations instead. It also simplifies the handling in the builder api client crate. It also allows us to build on newer versions of Ubuntu which have updated openssl libraries.
The cert handling changes allow more robustness and flexibility in the client. We now add the cacerts to the root certificate list instead of replacing it. We also allow dropping new SSL certs into the hab cache ssl directory that also get added to the root certificate list. Finally we can now support both PEM and DER cert formats.
The behavior in cert handling for the Mac platform has also been brought in line with the other platforms. Previously, we did basically left the Mac to its system certs. Now the same logic is used consistently.
Signed-off-by: Salim Alam email@example.com
christophermaier left a comment
Still working through this, but I've gotta run to dinner now.
Overall it's looking pretty good. I think we could take this opportunity to do some further cleanup, as there's still a lot of boilerplate. But I'm very much liking where it's going!
baumanj left a comment
This stuff looks good to me; since it's essentially all slight changes in interface, I'm not too concerned.
I'm really excited about these bits, and most of my suggestions are optional. However, I'm requesting changes because we're adding important functionality here, and there's no test coverage. I think we should use this opportunity to make sure we correct that.