Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing up some End-to-End Supervisor Tests #6780

Merged
merged 4 commits into from Aug 16, 2019

Conversation

@christophermaier
Copy link
Contributor

commented Aug 1, 2019

Enables the following end-to-end tests in our end-to-end pipeline:

@christophermaier christophermaier self-assigned this Aug 1, 2019
@chef-expeditor

This comment has been minimized.

Copy link

commented Aug 1, 2019

Hello christophermaier! Thanks for the pull request!

Here is what will happen next:

  1. Your PR will be reviewed by the maintainers.
  2. If everything looks good, one of them will approve it, and your PR will be merged.

Thank you for contributing!

@christophermaier christophermaier force-pushed the cm/end-to-end branch 9 times, most recently from 29352a9 to 17fa550 Aug 1, 2019
@christophermaier christophermaier force-pushed the cm/end-to-end branch 3 times, most recently from 45ffc0c to 961ff26 Aug 2, 2019
@christophermaier christophermaier force-pushed the cm/end-to-end branch 3 times, most recently from f111213 to 7c94195 Aug 5, 2019
@christophermaier christophermaier referenced this pull request Aug 12, 2019
8 of 8 tasks complete
@christophermaier christophermaier force-pushed the cm/end-to-end branch from 7c94195 to 91e0700 Aug 14, 2019
@christophermaier christophermaier force-pushed the cm/end-to-end branch 3 times, most recently from 20155f1 to 1c3ad00 Aug 16, 2019
@christophermaier christophermaier changed the title Fixing up End-to-End Supervisor Tests Fixing up some End-to-End Supervisor Tests Aug 16, 2019
@christophermaier christophermaier force-pushed the cm/end-to-end branch from 1c3ad00 to f851436 Aug 16, 2019
@christophermaier christophermaier marked this pull request as ready for review Aug 16, 2019
Copy link
Contributor

left a comment

Huzzah!

It appears that adding `HAB_BLDR_URL=$ACCEPTANCE_HAB_BLDR_URL` in a
step definition doesn't properly do the interpolation we want, and
instead sets `HAB_BLDR_URL` to the empty string.

I suspect the interpolation is being done when the pipeline definition
is being uploaded to Buildkite, which is why the value is not set.

Signed-off-by: Christopher Maier <cmaier@chef.io>
Signed-off-by: Christopher Maier <cmaier@chef.io>
Signed-off-by: Christopher Maier <cmaier@chef.io>
Had to remove the `TESTING_FS_ROOT` environment variable, since it
wasn't completely isolating the filesystem in the way we were
expecting.

No biggie since the test is intended for a fresh system anyway.

Signed-off-by: Christopher Maier <cmaier@chef.io>
@christophermaier christophermaier force-pushed the cm/end-to-end branch from f851436 to bdbd106 Aug 16, 2019
@christophermaier christophermaier merged commit 0d241f3 into master Aug 16, 2019
5 checks passed
5 checks passed
DCO This commit has a DCO Signed-off-by
Details
buildkite/habitat-sh-habitat-master-verify Build #3150 passed (30 minutes, 48 seconds)
Details
buildkite/habitat-sh-habitat-master-website Build #277 passed (59 seconds)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
expeditor/config-validation Validated your Expeditor config file
Details
@chef-ci chef-ci deleted the cm/end-to-end branch Aug 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.