Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "redux: cross platform binstubs with package environment" #6796

Conversation

@smacfarlane
Copy link
Contributor

commented Aug 6, 2019

Reverts #6700

Ref: #6791

There an edge case with the studio and generating the binstubs that is preventing us from performing release builds, see #6791 for details.

For now, I think it's best we back this out and take this to a design doc to discuss the goals of the binlink command and explore any additional potential edge cases our users might encounter.

Signed-off-by: Scott Macfarlane smacfarlane@chef.io

@chef-expeditor

This comment has been minimized.

Copy link

commented Aug 6, 2019

Hello smacfarlane! Thanks for the pull request!

Here is what will happen next:

  1. Your PR will be reviewed by the maintainers.
  2. If everything looks good, one of them will approve it, and your PR will be merged.

Thank you for contributing!

@christophermaier

This comment has been minimized.

Copy link
Contributor

commented Aug 6, 2019

@smacfarlane are there any backward compatibility issues that this revert might introduce that would need to be addressed?

@baumanj
baumanj approved these changes Aug 6, 2019
@smacfarlane

This comment has been minimized.

Copy link
Contributor Author

commented Aug 7, 2019

@christophermaier We haven't released this change yet so from that perspective we should be safe. There are builds of 0.84.x from the release pipeline work on builder, which gives me a little pause, but they've remained in the unstable or 'fake-0.84' channels.

I'm re-reading the commit history since this change, but a quick examination didn't show any additional changes in these files.

@mwrock

This comment has been minimized.

Copy link
Contributor

commented Aug 7, 2019

I'm just catching up from vacation and have not read in to this yet. Before we merge this is like the chance to have a look. And at the least just revert the Linux implementation.

Signed-off-by: Scott Macfarlane <smacfarlane@chef.io>
@smacfarlane smacfarlane force-pushed the revert-6700-revert-6689-revert-6670-jamessewell-binlinkstubs branch from 102e515 to 3745bd2 Aug 7, 2019
@smacfarlane smacfarlane merged commit f9ec964 into master Aug 7, 2019
5 checks passed
5 checks passed
DCO This commit has a DCO Signed-off-by
Details
buildkite/habitat-sh-habitat-master-verify Build #2966 passed (30 minutes, 10 seconds)
Details
buildkite/habitat-sh-habitat-master-website Build #95 passed and blocked (14 seconds)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
expeditor/config-validation Validated your Expeditor config file
Details
@chef-ci chef-ci deleted the revert-6700-revert-6689-revert-6670-jamessewell-binlinkstubs branch Aug 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.