Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add environment to windows binstubs #6826

Conversation

@mwrock
Copy link
Contributor

commented Aug 9, 2019

This takes what was reverted in #6796 and adds back just the Windows pieces.

There was some light refactoring that does affect both platforms but this only contains material behavior changes for Windows. Namely it adds the environment to the binstub.

@chef-expeditor

This comment has been minimized.

Copy link

commented Aug 9, 2019

Hello mwrock! Thanks for the pull request!

Here is what will happen next:

  1. Your PR will be reviewed by the maintainers.
  2. If everything looks good, one of them will approve it, and your PR will be merged.

Thank you for contributing!

@mwrock mwrock force-pushed the revert-6796-revert-6700-revert-6689-revert-6670-jamessewell-binlinkstubs branch from 9378cff to 5e5f00c Aug 9, 2019
Signed-off-by: mwrock <matt@mattwrock.com>
@mwrock mwrock force-pushed the revert-6796-revert-6700-revert-6689-revert-6670-jamessewell-binlinkstubs branch from 5e5f00c to 6eca46e Aug 9, 2019
@mwrock mwrock marked this pull request as ready for review Aug 9, 2019
@baumanj
baumanj approved these changes Aug 9, 2019
@mwrock mwrock merged commit 57de486 into master Aug 9, 2019
5 checks passed
5 checks passed
DCO This commit has a DCO Signed-off-by
Details
buildkite/habitat-sh-habitat-master-verify Build #3007 passed (30 minutes, 59 seconds)
Details
buildkite/habitat-sh-habitat-master-website Build #136 passed (3 minutes, 43 seconds)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
expeditor/config-validation Validated your Expeditor config file
Details
@mwrock mwrock deleted the revert-6796-revert-6700-revert-6689-revert-6670-jamessewell-binlinkstubs branch Aug 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.