Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add job to run all `#[ignore]`d tests #6845

Merged
merged 2 commits into from Aug 14, 2019

Conversation

@baumanj
Copy link
Contributor

commented Aug 13, 2019

Also, fix up broken doc tests and remove their ignore annotation.

@chef-expeditor

This comment has been minimized.

Copy link

commented Aug 13, 2019

Hello baumanj! Thanks for the pull request!

Here is what will happen next:

  1. Your PR will be reviewed by the maintainers.
  2. If everything looks good, one of them will approve it, and your PR will be merged.

Thank you for contributing!

@baumanj baumanj force-pushed the run-all-ignored-tests branch from 8d50158 to 6d387c7 Aug 13, 2019
Also, fix up broken doc tests and remove their `ignore` annotation.

Signed-off-by: Jon Bauman <5906042+baumanj@users.noreply.github.com>
@baumanj baumanj force-pushed the run-all-ignored-tests branch from 6d387c7 to 043d5af Aug 13, 2019
@baumanj baumanj marked this pull request as ready for review Aug 13, 2019
@baumanj baumanj requested a review from mwrock Aug 13, 2019
Copy link
Contributor

left a comment

Yesssssss

Write-Host "--- Running cargo +$toolchain test on $Component with command: '$CargoTestCommand'"
cd components/$Component

if($Component -eq "") {

This comment has been minimized.

Copy link
@mwrock

mwrock Aug 14, 2019

Contributor

if no -Component is passed, then $Component will be $null and not empty. So should be if(!$Component).

This comment has been minimized.

Copy link
@baumanj

baumanj Aug 14, 2019

Author Contributor

That looks better, thanks! I'll make that change shortly.

For my own edification, testing -eq "" seems to work as well. Is that expected, or is there something I'm missing?

This comment has been minimized.

Copy link
@baumanj

baumanj Aug 14, 2019

Author Contributor

Fixed in 6098da2

This comment has been minimized.

Copy link
@mwrock

mwrock Aug 14, 2019

Contributor

Arg. thats right. It is initialized as a [string] and thus has "" as a default value and not $null. sorry!!

This comment has been minimized.

Copy link
@baumanj

baumanj Aug 14, 2019

Author Contributor

This approach works too, and seems more robust. And I learned something, so no need to apologize! Can I get an approval though?

Signed-off-by: Jon Bauman <5906042+baumanj@users.noreply.github.com>
@mwrock
mwrock approved these changes Aug 14, 2019
@baumanj baumanj merged commit 3877e11 into master Aug 14, 2019
5 checks passed
5 checks passed
DCO This commit has a DCO Signed-off-by
Details
buildkite/habitat-sh-habitat-master-verify Build #3092 passed (24 minutes, 26 seconds)
Details
buildkite/habitat-sh-habitat-master-website Build #220 passed (33 seconds)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
expeditor/config-validation Validated your Expeditor config file
Details
@baumanj baumanj deleted the run-all-ignored-tests branch Aug 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.