Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes supervisor connection failure test #6860

Merged
merged 2 commits into from Aug 27, 2019

Conversation

@nellshamrell
Copy link
Contributor

commented Aug 16, 2019

This is a partial fix for #6816 - this fixes these two tests:

This also pulls in the work in #6887 - #6887 should be merged before this is merged.

@chef-expeditor

This comment has been minimized.

Copy link

commented Aug 16, 2019

Hello nellshamrell! Thanks for the pull request!

Here is what will happen next:

  1. Your PR will be reviewed by the maintainers.
  2. If everything looks good, one of them will approve it, and your PR will be merged.

Thank you for contributing!

@nellshamrell nellshamrell force-pushed the nshamrell/fix-sup-tests branch 2 times, most recently from 0a9514d to 021465d Aug 21, 2019
…ontainers, rather than explicitly specifying it

Signed-off-by: Scott Hain <shain@chef.io>
@nellshamrell nellshamrell force-pushed the nshamrell/fix-sup-tests branch 2 times, most recently from 63a46e8 to dd24e2e Aug 21, 2019
… test

Signed-off-by: Nell Shamrell <nellshamrell@gmail.com>
@nellshamrell nellshamrell force-pushed the nshamrell/fix-sup-tests branch from ddd083c to 6ee32e5 Aug 21, 2019
@christophermaier christophermaier referenced this pull request Aug 21, 2019
8 of 8 tasks complete
@nellshamrell nellshamrell marked this pull request as ready for review Aug 21, 2019
@nellshamrell nellshamrell merged commit b86fa67 into master Aug 27, 2019
4 of 5 checks passed
4 of 5 checks passed
buildkite/habitat-sh-habitat-master-verify Build #3216 passed and blocked (18 seconds)
Details
DCO This commit has a DCO Signed-off-by
Details
buildkite/habitat-sh-habitat-master-website Build #337 passed and blocked (16 seconds)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
expeditor/config-validation Validated your Expeditor config file
Details
@chef-ci chef-ci deleted the nshamrell/fix-sup-tests branch Aug 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.