Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add one-off release tool #6885

Merged
merged 3 commits into from Aug 28, 2019

Conversation

@davidMcneil
Copy link
Contributor

commented Aug 21, 2019

This documents the one-off release process and adds a tool to help automate the process.

Resolves #6869

Signed-off-by: David McNeil mcneil.david2@gmail.com

@chef-expeditor

This comment has been minimized.

Copy link

commented Aug 21, 2019

Hello davidMcneil! Thanks for the pull request!

Here is what will happen next:

  1. Your PR will be reviewed by the maintainers.
  2. If everything looks good, one of them will approve it, and your PR will be merged.

Thank you for contributing!

Signed-off-by: David McNeil <mcneil.david2@gmail.com>
@davidMcneil davidMcneil force-pushed the dmcneil/one-off-release-tool branch from 5ea2303 to 2079141 Aug 21, 2019
@raskchanky

This comment has been minimized.

Copy link
Member

commented Aug 21, 2019

I have concerns about one-off releases in general that might be better discussed offline.

Signed-off-by: David McNeil <mcneil.david2@gmail.com>
Copy link
Member

left a comment

I'd love if we could put a large and difficult to miss warning in the docs that says something to the effect of "One-off builds are generally a terrible idea and should be used with extreme caution and as a last resort only". Feel free to wordsmith as necessary.

I get that sometimes we need to make one-off builds because there's some kind of customer need, but I just want us to be clear that having a tool that makes them easier isn't a reason to do more of them.

Signed-off-by: David McNeil <mcneil.david2@gmail.com>
@davidMcneil davidMcneil requested a review from raskchanky Aug 28, 2019
@davidMcneil davidMcneil merged commit 1bef877 into master Aug 28, 2019
5 checks passed
5 checks passed
DCO This commit has a DCO Signed-off-by
Details
buildkite/habitat-sh-habitat-master-verify Build #3263 passed (40 minutes, 19 seconds)
Details
buildkite/habitat-sh-habitat-master-website Build #384 passed (42 seconds)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
expeditor/config-validation Validated your Expeditor config file
Details
@chef-ci chef-ci deleted the dmcneil/one-off-release-tool branch Aug 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.