Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

report last error after all failed pkg download attempts #6890

Merged
merged 1 commit into from Aug 22, 2019

Conversation

@mwrock
Copy link
Contributor

commented Aug 22, 2019

When downloading packages we retry up to 5 times when there is any failure. However the true inner error is never reported back which can make debugging difficult. This bubbles up the error message of the last attempt.

For example, the current state of master has a bug that will fail on chunked transfer encoding because there is no CONTENT_LENGTH header. In such a case this PR would result in the final error output being:

XXX
XXX We tried 5 times but could not download core/visual-build-tools-2017/15/20190808171719. Last error was: Missing header
XXX                                                                                                                     

Signed-off-by: mwrock matt@mattwrock.com

@chef-expeditor

This comment has been minimized.

Copy link

commented Aug 22, 2019

Hello mwrock! Thanks for the pull request!

Here is what will happen next:

  1. Your PR will be reviewed by the maintainers.
  2. If everything looks good, one of them will approve it, and your PR will be merged.

Thank you for contributing!

@mwrock mwrock force-pushed the retry_err branch from 33bd08d to d1d6be1 Aug 22, 2019
# using https://mexus.github.io/rustup-components-history/x86_64-unknown-linux-gnu.html
Get-Content "$PSScriptRoot\..\..\RUSTFMT_VERSION"
}

This comment has been minimized.

Copy link
@mwrock

mwrock Aug 22, 2019

Author Contributor

This got inadvertantly lost in the recent script cleanup and was preventing me from running rustfmt

@markan
markan approved these changes Aug 22, 2019
Copy link
Contributor

left a comment

Looks reasonable to me.

Copy link
Contributor

left a comment

Looks good; just a small suggestion

components/common/src/command/package/install.rs Outdated Show resolved Hide resolved
@eeyun
eeyun approved these changes Aug 22, 2019
Signed-off-by: mwrock <matt@mattwrock.com>
@mwrock mwrock force-pushed the retry_err branch from d1d6be1 to 5b25d6b Aug 22, 2019
@mwrock mwrock merged commit 731c8c8 into master Aug 22, 2019
5 checks passed
5 checks passed
DCO This commit has a DCO Signed-off-by
Details
buildkite/habitat-sh-habitat-master-verify Build #3222 passed (32 minutes, 9 seconds)
Details
buildkite/habitat-sh-habitat-master-website Build #343 passed (33 seconds)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
expeditor/config-validation Validated your Expeditor config file
Details
@chef-ci chef-ci deleted the retry_err branch Aug 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.