Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds channel-to-channel promotion to bldr subcommand #6911

Merged
merged 1 commit into from Aug 30, 2019

Conversation

@eeyun
Copy link
Contributor

commented Aug 28, 2019

Signed-off-by: Ian Henry ihenry@chef.io

@chef-expeditor

This comment has been minimized.

Copy link

commented Aug 28, 2019

Hello eeyun! Thanks for the pull request!

Here is what will happen next:

  1. Your PR will be reviewed by the maintainers.
  2. If everything looks good, one of them will approve it, and your PR will be merged.

Thank you for contributing!

components/hab/src/cli.rs Outdated Show resolved Hide resolved
components/hab/src/cli.rs Outdated Show resolved Hide resolved
components/hab/src/cli.rs Outdated Show resolved Hide resolved
components/hab/src/cli.rs Outdated Show resolved Hide resolved
components/hab/src/main.rs Outdated Show resolved Hide resolved
Copy link
Member

left a comment

Looks good to me, just a few wordsmithing comments...

@eeyun eeyun force-pushed the eeyun/channel_promote branch from 3787014 to 6b98a6f Aug 28, 2019
@baumanj baumanj added the X-feature label Aug 29, 2019
Copy link
Contributor

left a comment

I don't see any logic flaws with the code, and the suggestions I have are all fairly minor and optional.

My biggest concern is that we're adding new functionality without any test coverage. I can think of a couple different approaches we could take for that here. Let me know if you'd like to discuss.

components/builder-api-client/src/builder.rs Outdated Show resolved Hide resolved
components/hab/src/cli.rs Show resolved Hide resolved
components/hab/src/cli.rs Show resolved Hide resolved
components/builder-api-client/src/builder.rs Outdated Show resolved Hide resolved
components/hab/src/main.rs Outdated Show resolved Hide resolved
components/hab/src/main.rs Outdated Show resolved Hide resolved
components/hab/src/main.rs Outdated Show resolved Hide resolved
components/builder-api-client/src/builder.rs Outdated Show resolved Hide resolved
@eeyun eeyun force-pushed the eeyun/channel_promote branch 2 times, most recently from fc4e0d5 to 585328f Aug 29, 2019
Signed-off-by: Ian Henry <ihenry@chef.io>
@eeyun eeyun force-pushed the eeyun/channel_promote branch from 585328f to 9574116 Aug 29, 2019
@chefsalim chefsalim merged commit ce1fc00 into master Aug 30, 2019
5 checks passed
5 checks passed
DCO This commit has a DCO Signed-off-by
Details
buildkite/habitat-sh-habitat-master-verify Build #3283 passed (22 minutes, 19 seconds)
Details
buildkite/habitat-sh-habitat-master-website Build #402 passed and blocked (16 seconds)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
expeditor/config-validation Validated your Expeditor config file
Details
@chefsalim chefsalim deleted the eeyun/channel_promote branch Aug 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.