Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always build the Launcher and Windows Service packages #6916

Merged
merged 1 commit into from Sep 4, 2019

Conversation

@christophermaier
Copy link
Contributor

commented Aug 28, 2019

Previously, we would only build Launcher and Windows Service packages
only if a user indicated manually that they should be built. As we
move toward a continuous release model, this manual step becomes
cumbersome. In any event, an engineer will still have to evaluate
what has changed in the Launcher and Windows Service since the last
release in order to determine whether end-users will need to update
their Launcher packages. As a result, we're not really removing a
human quality gate here; we're just simplifying the pipeline.

For reviewers: the only concrete change here is making the existing
build steps run all the time; the content of the steps hasn't changed.

Signed-off-by: Christopher Maier cmaier@chef.io

Previously, we would only build Launcher and Windows Service packages
only if a user indicated manually that they should be built. As we
move toward a continuous release model, this manual step becomes
cumbersome. In any event, an engineer will _still_ have to evaluate
what has changed in the Launcher and Windows Service since the last
release in order to determine whether end-users will need to update
their Launcher packages. As a result, we're not really removing a
human quality gate here; we're just simplifying the pipeline.

For reviewers: the only concrete change here is making the existing
build steps run all the time; the content of the steps hasn't changed.

Signed-off-by: Christopher Maier <cmaier@chef.io>
@chef-expeditor

This comment has been minimized.

Copy link

commented Aug 28, 2019

Hello christophermaier! Thanks for the pull request!

Here is what will happen next:

  1. Your PR will be reviewed by the maintainers.
  2. If everything looks good, one of them will approve it, and your PR will be merged.

Thank you for contributing!

@mwrock
mwrock approved these changes Aug 28, 2019
Copy link
Contributor

left a comment

No my expertise, but no objections either

@christophermaier christophermaier merged commit 0c9d5e6 into master Sep 4, 2019
5 checks passed
5 checks passed
DCO This commit has a DCO Signed-off-by
Details
buildkite/habitat-sh-habitat-master-verify Build #3264 passed (36 minutes, 27 seconds)
Details
buildkite/habitat-sh-habitat-master-website Build #385 passed (35 seconds)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
expeditor/config-validation Validated your Expeditor config file
Details
@chef-ci chef-ci deleted the cm/always-build-launcher branch Sep 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.